Page MenuHomePhabricator
Create Task
Maniphest T203114

2017 source editor trimmed whitespace inside a "source" block
Closed, ResolvedPublic
Actions

Description

See the diff, https://www.mediawiki.org/w/index.php?title=Extension:JADE&diff=prev&oldid=2865214&diffmode=source

Leading whitespace was stripped from each line of my <source> blocks.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (7420443fe)mediawiki/extensions/VisualEditormaster+18 -31
[BREAKING CHANGE] Implement a SourceConverterVisualEditor/VisualEditormaster+208 -51
Always treat whitespace as significant when converting for source modeVisualEditor/VisualEditormaster+36 -2
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Aug 29 2018, 8:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2018, 8:30 PM
Esanders renamed this task from 2017 source editor trimmed whitespace inside a "code" block to 2017 source editor trimmed whitespace inside a "source" block.Aug 30 2018, 10:46 AM
Esanders added a project: SyntaxHighlight.
Esanders updated the task description. (Show Details)
Esanders subscribed.

Looks like this happens as soon as the document is loaded: https://www.mediawiki.org/wiki/Extension:JADE?veaction=editsource&section=8

Esanders triaged this task as High priority.Aug 30 2018, 10:52 AM

This issue will be that we convert the line into "<p>[TAB][TAB]mycode</p>" and the visual editor converter turns leading/trailing whitespace inside a tag into a internal property - that gets restored when we convert back to HTML, although in 2017 source editor we used an optimised method for converting back to HTML.

We should disable the internal whitespace stripping in the converter when in source mode.

Esanders added a subscriber: • Deskana.Aug 30 2018, 10:53 AM

This fix shouldn't be too hard, and this might be a UBN, thoughts @Deskana ?

• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.Aug 30 2018, 11:18 AM

Let's take care of it, since it should be quick.

Esanders claimed this task.Aug 30 2018, 12:10 PM
gerritbot subscribed.Aug 30 2018, 12:30 PM

Change 456381 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Always treat whitespace as significant when converting for source mode

https://gerrit.wikimedia.org/r/456381

gerritbot added a project: Patch-For-Review.Aug 30 2018, 12:30 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Aug 30 2018, 12:34 PM
Esanders added a comment.Aug 30 2018, 12:57 PM

The fix is a bit hacky, I'll file some tech debt to follow-up.

Esanders mentioned this in T203156: Refactor source mode conversion.Aug 30 2018, 1:07 PM

Filed as T203156

gerritbot added a comment.Sep 6 2018, 1:33 PM

Change 458490 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Implement a SourceConverter

https://gerrit.wikimedia.org/r/458490

gerritbot added a comment.Sep 14 2018, 10:10 AM

Change 458490 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Implement a SourceConverter

https://gerrit.wikimedia.org/r/458490

gerritbot added a comment.Sep 14 2018, 10:16 AM

Change 458489 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7420443fe)

https://gerrit.wikimedia.org/r/458489

gerritbot added a comment.Sep 14 2018, 10:19 AM

Change 456381 abandoned by Bartosz Dziewoński:
Always treat whitespace as significant when converting for source mode

Reason:
Superseded by https://gerrit.wikimedia.org/r/458490

https://gerrit.wikimedia.org/r/456381

gerritbot added a comment.Sep 14 2018, 11:00 AM

Change 458489 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7420443fe)

https://gerrit.wikimedia.org/r/458489

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 14 2018, 11:11 AM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed Patch-For-Review.Sep 14 2018, 9:24 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-2017WikitextEditor.
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 28 2018, 10:15 PM
• Deskana closed this task as Resolved.Oct 1 2018, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL