Page MenuHomePhabricator

[FundraisingLandingPage] should not double escape
Open, Needs TriagePublic

Description

Follow-up from https://gerrit.wikimedia.org/r/455290 by @Bawolff

I think that what FundraisingLandingPage is doing here is rather silly and should be changed, but given its intentional, the suppression makes sense.

The suppression of the warning is merely a workaround, that function should not be escaping both for wikitext and HTML.

Event Timeline

Legoktm created this task.Aug 30 2018, 7:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2018, 7:33 AM

Hi! Thanks much for finding this cruft!!!

It's clear that it should be fixed... Still, I'd like to delay doing so until after the new FR EventLogging pipeline is fully tested and deployed (see T183978).

Thanks again!!