Page MenuHomePhabricator

SkinPerPage should validate the skin name
Open, Needs TriagePublic

Description

If given an invalid skin name, it should return something like

Html::element( 'span', [ 'class' => 'error'], wfMessage( 'skinperpage-noskin' )->text() );

Where skinperpage-noskin is an error message defined in i18n/en.json.

Event Timeline

Hello I would like to work on this task. @Bawolff can you please help me to find code base repository and also could you please update the task description.

@Nithinreddy18: Hi and welcome! Please see https://www.mediawiki.org/wiki/Extension:SkinPerPage for information and links to the Gerrit repository.
And if you think that there is a need to update the task description, please explain why you think that there is a need to update the task description. :)

I thought it would be easier if the link for extension and manual adding code in localsettings.php are mentioned in the description.

Aklapper added a subscriber: Nithinreddy18.

@Nithinreddy18: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Change 696382 had a related patch set uploaded (by Aklapper; author: Mnowicka):

[mediawiki/extensions/SkinPerPage@master] SkinPerPage should validate the skin name

https://gerrit.wikimedia.org/r/696382

Change 696382 merged by jenkins-bot:

[mediawiki/extensions/SkinPerPage@master] Validate the given skin name and warn when it's unknown

https://gerrit.wikimedia.org/r/696382