Maniphest T203143

SkinPerPage should validate the skin name
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Aug 30 2018, 7:53 AM

Description

If given an invalid skin name, it should return something like

Html::element( 'span', [ 'class' => 'error'], wfMessage( 'skinperpage-noskin' )->text() );

Where skinperpage-noskin is an error message defined in i18n/en.json.

Details

	Subject	Repo	Branch	Lines +/-
	Validate the given skin name and warn when it's unknown	mediawiki/extensions/SkinPerPage	master	+18 -3

Customize query in gerrit

Related Objects

Mentioned In: T203095: Security review for EUCopyrightCampaign extension and EUCopyrightCampaignSkin

Event Timeline

Bawolff created this task.Aug 30 2018, 7:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2018, 7:53 AM

Legoktm added a project: MediaWiki-extensions-Other.Aug 30 2018, 7:55 AM

Legoktm updated the task description. (Show Details)

Bawolff mentioned this in T203095: Security review for EUCopyrightCampaign extension and EUCopyrightCampaignSkin.Aug 30 2018, 8:41 AM

Liuxinyu970226 edited subscribers, added: • tstarling; removed: MediaWiki-extensions-Other.Aug 30 2018, 2:15 PM

Framawiki subscribed.Aug 30 2018, 5:06 PM

Nithinreddy18 claimed this task.Nov 5 2018, 12:48 PM

Hello I would like to work on this task. @Bawolff can you please help me to find code base repository and also could you please update the task description.

@Nithinreddy18: Hi and welcome! Please see https://www.mediawiki.org/wiki/Extension:SkinPerPage for information and links to the Gerrit repository.
And if you think that there is a need to update the task description, please explain why you think that there is a need to update the task description. :)

I thought it would be easier if the link for extension and manual adding code in localsettings.php are mentioned in the description.

DannyS712 edited projects, added MediaWiki-extensions-SkinPerPage; removed MediaWiki-extensions-Other.Mar 4 2020, 1:24 AM

@Nithinreddy18: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!