Maniphest T203145

Vagrant 2.1.[3-5] - NameError: uninitialized constant MediaWikiVagrant::Environment
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	zeljkofilipin
	Aug 30 2018, 8:03 AM

Description

Reproducible with vagrant 2.1.3, 2.1.4 and 2.1.5.

$ git log --oneline -1
347e0849 (HEAD -> master, origin/master, origin/HEAD) Send Thumbor-Request-Id in haproxy response

$ vagrant -v
Vagrant 2.1.3

$ vagrant up
Vagrant failed to initialize at a very early stage:

There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.

Path: /Users/z/Documents/gerrit/mediawiki/vagrant/Vagrantfile
Line number: 48
Message: NameError: uninitialized constant MediaWikiVagrant::Environment

Workaround is to install Vagrant 2.1.2.

Details

	Subject	Repo	Branch	Lines +/-
	Fix NameError: uninitialized constant MediaWikiVagrant::Environment	mediawiki/vagrant	master	+5 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment

Event Timeline

zeljkofilipin created this task.Aug 30 2018, 8:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2018, 8:03 AM

zeljkofilipin triaged this task as High priority.Aug 30 2018, 8:04 AM

zeljkofilipin moved this task from Backlog 🪒 to Waiting 🏹 on the User-zeljkofilipin board.

zeljkofilipin updated the task description. (Show Details)Aug 30 2018, 8:06 AM

zeljkofilipin merged a task: T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment.Sep 1 2018, 2:33 PM

zeljkofilipin added subscribers: • brion, Reedy, • Niedzielski and 2 others.

zeljkofilipin updated the task description. (Show Details)Sep 3 2018, 2:55 PM

Upstream issue: https://github.com/hashicorp/vagrant/issues/10161

bd808 renamed this task from NameError: uninitialized constant MediaWikiVagrant::Environment to Vagrant 2.1.3 and 2.1.4 - NameError: uninitialized constant MediaWikiVagrant::Environment.Sep 3 2018, 9:05 PM

Adding the Upstream tag because the root cause here is a not-quite-right change upstream that is breaking repo-local plugin initialization.

Agabi10 subscribed.Sep 3 2018, 9:11 PM

zeljkofilipin awarded a token.Sep 4 2018, 8:20 AM

Agabi10 moved this task from Backlog to Patch merged upstream on the Upstream board.Sep 4 2018, 6:20 PM

2.1.5 is out, https://github.com/hashicorp/vagrant/issues/10161 is closed...

Nope, still broken

Sams-MBP:vagrant reedy$ vagrant box update
Vagrant failed to initialize at a very early stage:

There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.

Path: /Users/reedy/vagrant/Vagrantfile
Line number: 48
Message: NameError: uninitialized constant MediaWikiVagrant::Environment
Sams-MBP:vagrant reedy$ vagrant --version
Vagrant 2.1.5

Reedy renamed this task from Vagrant 2.1.3 and 2.1.4 - NameError: uninitialized constant MediaWikiVagrant::Environment to Vagrant 2.1.[3-5] - NameError: uninitialized constant MediaWikiVagrant::Environment.Sep 13 2018, 11:11 PM

Reedy updated the task description. (Show Details)

Reedy changed Risk Rating from N/A to default.

Not sure why, but adding

require './lib/mediawiki-vagrant/environment.rb'

to the Vagrantfile fixed this for me in Vagrant 2.1.5/Virtualbox 5.2.18/Ruby 2.3.7 on High Sierra.

In T203145#4595480, @sbassett wrote:
Not sure why, but adding
require './lib/mediawiki-vagrant/environment.rb'
to the Vagrantfile fixed this for me in Vagrant 2.1.5/Virtualbox 5.2.18/Ruby 2.3.7 on High Sierra.

Seems reasonable enough as they've changed something related to the plugin loading infrastructure

Make a patch? :)

Change 461232 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/vagrant@master] Fix NameError: uninitialized constant MediaWikiVagrant::Environment

https://gerrit.wikimedia.org/r/461232

gerritbot added a project: Patch-For-Review.Sep 18 2018, 9:55 PM

• Mholloway subscribed.Sep 19 2018, 5:00 AM

Change 461232 merged by jenkins-bot:
[mediawiki/vagrant@master] Fix NameError: uninitialized constant MediaWikiVagrant::Environment

https://gerrit.wikimedia.org/r/461232

@brion tested the patch from @sbassett on both mac and windows I believe. Lets call this closed until someone proves otherwise.

zeljkofilipin rescinded a token.Sep 20 2018, 8:41 AM

zeljkofilipin awarded a token.

Vagrant 2.1.[3-5] - NameError: uninitialized constant MediaWikiVagrant::EnvironmentClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Vagrant 2.1.[3-5] - NameError: uninitialized constant MediaWikiVagrant::Environment
Closed, ResolvedPublic
Actions