Page MenuHomePhabricator

License note on jsonconfig pages
Closed, ResolvedPublic

Description

When you try to edit page like: https://meta.wikimedia.org/wiki/Config:Dashiki:SimpleRequestBreakdowns

You see (at the top) a notice like:

"Note: When you edit this page, you agree to release your contribution according to the license specified in the 'licence' field."

even though there's no such field on JsonConfig pages which aren't Commons data pages.

Event Timeline

True for Zero-namespaced pages on Zerowiki as well.

Maybe we should revert https://gerrit.wikimedia.org/r/c/mediawiki/extensions/JsonConfig/+/450397/ until the bugs are fixed. This is the fifth bug caused by it, by my count.

Maybe we should revert https://gerrit.wikimedia.org/r/c/mediawiki/extensions/JsonConfig/+/450397/ until the bugs are fixed. This is the fifth bug caused by it, by my count.

+1 to reverting. The patch needs checks throughout that it's dealing specifically with JCDataContent rather than some other JCContent, and then thorough testing to ensure that it's not having effects where it shouldn't.