Page MenuHomePhabricator
Create Task
Maniphest T203213

Visual Editor works as LTR in all RTL Wikimedia wikis
Closed, ResolvedPublic
Actions

Description

When editing pages in Visual Editor, the text appears from left to right in right-to-left wikis. It's supposed to appear from right to left, of course.

This happens in all RTL wikis: Hebrew, Yiddish, Persian, Arabic. I reproduced it on Windows, Firefox 61 and Chrome 68.

From Special:Version: This in MediaWiki 1.32.0-wmf.19 (rMW0b2f56ab74cb), VisualEditor 0.1.0 (bf9d3c1).

Marking as Unbreak Now, because it makes VE almost unusable in these wikis.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1Fix typo in mw.Target#setupSurface
mediawiki/extensions/VisualEditorwmf/1.32.0-wmf.19+1 -1Fix typo in mw.Target#setupSurface
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Aug 31 2018, 5:57 AM
Restricted Application added a project: I18n. · View Herald TranscriptAug 31 2018, 5:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 triaged this task as Unbreak Now! priority.Aug 31 2018, 5:57 AM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptAug 31 2018, 5:57 AM
Amire80 added a subscriber: eranroz.Aug 31 2018, 5:58 AM
eranroz added a subscriber: Jdforrester-WMF.Aug 31 2018, 8:08 AM

This also set the .ve-ce-documentNode lang as en - e.g in dewiki the document language is English. (the defaults comes from 50c4efd1d5ae8942ac1284195f8a44c8e2bcd537 - though this is old change and clearly not directly blamed for this bug...)

Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.Aug 31 2018, 10:03 AM
Deskana added a subscriber: Deskana.

Needs urgent attention.

Deskana added a subscriber: Ryasmeen.Aug 31 2018, 10:04 AM

@Ryasmeen We should figure out how this slipped through QA.

Amire80 added a comment.Aug 31 2018, 10:42 AM
In T203213#4547836, @Deskana wrote:

Needs urgent attention.

Thanks for confirming! :)

In T203213#4547838, @Deskana wrote:

@Ryasmeen We should figure out how this slipped through QA.

Do you have a procedure of testing on RTL? If not, I have some written docs that may help you start it.

Esanders claimed this task.Aug 31 2018, 12:07 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
IKhitron added a subscriber: IKhitron.Aug 31 2018, 12:14 PM
gerritbot added a subscriber: gerritbot.Aug 31 2018, 12:17 PM

Change 456610 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix typo in mw.Target#setupSurface

https://gerrit.wikimedia.org/r/456610

gerritbot added a project: Patch-For-Review.Aug 31 2018, 12:17 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 31 2018, 12:17 PM
gerritbot added a comment.Aug 31 2018, 1:02 PM

Change 456610 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix typo in mw.Target#setupSurface

https://gerrit.wikimedia.org/r/456610

Deskana added a comment.Aug 31 2018, 1:23 PM

We should get this backported and deployed today, since it's a really bad breakage that we don't want hanging around over the weekend.

Esanders added a comment.Aug 31 2018, 1:47 PM

Definitely.

I've also added unit tests in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/456629/ to cover this particular issue.

Esanders added a comment.Aug 31 2018, 1:50 PM

Verified on beta: https://fa.wikipedia.beta.wmflabs.org/wiki/تغییر_مسیر?veaction=edit

Amire80 added a comment.Aug 31 2018, 1:52 PM
In T203213#4548555, @Deskana wrote:

We should get this backported and deployed today, since it's a really bad breakage that we don't want hanging around over the weekend.

Thank you so much <3

gerritbot added a comment.Aug 31 2018, 1:54 PM

Change 456631 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.19] Fix typo in mw.Target#setupSurface

https://gerrit.wikimedia.org/r/456631

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 31 2018, 2:00 PM
Deskana merged a task: T203252: Problem in visual editor direction in right to left wikis.Aug 31 2018, 2:02 PM
Deskana added a subscriber: alaa.
Esanders merged a task: T203257: Visual editor on rtl wikis shows as ltr.Aug 31 2018, 3:13 PM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.
Esanders added a subscriber: Kipod.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.Aug 31 2018, 4:07 PM
gerritbot added a comment.Aug 31 2018, 4:26 PM

Change 456631 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.19] Fix typo in mw.Target#setupSurface

https://gerrit.wikimedia.org/r/456631

Stashbot added a subscriber: Stashbot.Aug 31 2018, 4:30 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-31T16:30:16Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.19/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.Target.js: Hot-deploy of I38eda4aac48 to fix T203213 (duration: 00m 54s)

Jdforrester-WMF removed a project: Patch-For-Review.Aug 31 2018, 4:31 PM

Now hot-deployed to production.

Esanders added a comment.Aug 31 2018, 4:37 PM

Verified on live: https://fa.wikipedia.org/w/index.php?title=میکسر_تلویزیونی&veaction=edit

Amire80 added a comment.Aug 31 2018, 4:45 PM

Yep, verified in Hebrew, too.

Thanks for the quick fix!

Can be marked as resolved as far as I'm concerned.

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 31 2018, 5:00 PM
Deskana closed this task as Resolved.Sep 2 2018, 12:11 PM
Deskana moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Thanks for the report! Sorry about this one, folks.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 2 2018, 12:11 PM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Sep 4 2018, 2:18 PM
Ryasmeen added a comment.Sep 4 2018, 9:56 PM
In T203213#4548084, @Amire80 wrote:
In T203213#4547838, @Deskana wrote:

@Ryasmeen We should figure out how this slipped through QA.

Do you have a procedure of testing on RTL? If not, I have some written docs that may help you start it.

@Amire80: I don't actually. I realized it is not covered as part of my regular regression cycle. Would definitely like to get started and include it from now on.

Ryasmeen added a project: Verified.Sep 4 2018, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL