Page MenuHomePhabricator

convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class
Closed, DeclinedPublic

Description

Converting it to use a subclass of the Maintenance class ensures that a nice help text is present when passing --help. It will also help phan-taint-check-plugin detect that certain issues are false positive.

Relavent files are:

  • Scribunto/includes/engines/LuaCommon/lualib/ustring/make-table.php
  • Scribunto/includes/engines/LuaCommon/lualib/ustring/make-normalization-table.php

Event Timeline

Bawolff created this task.Aug 31 2018, 6:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 6:56 AM
Legoktm updated the task description. (Show Details)Aug 31 2018, 7:11 AM
Anomie added a subscriber: Anomie.Aug 31 2018, 1:47 PM

Note that the files in includes/engines/LuaCommon/lualib/ustring/ are intended to be able to be extracted and used in other non-MediaWiki Lua projects. Using the MediaWiki-specific Maintenance class would go against that goal.

Bawolff closed this task as Declined.Aug 31 2018, 3:23 PM

Note that the files in includes/engines/LuaCommon/lualib/ustring/ are intended to be able to be extracted and used in other non-MediaWiki Lua projects. Using the MediaWiki-specific Maintenance class would go against that goal.

Ah ok, I didn't realize that. This should be declined then.