Maniphest T203251

Allow report page tests to run offline
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lokal_Profil
	Aug 31 2018, 2:00 PM

Description

As is the tests of "statistics output" all call the live api as part of the Site (or Site+Page) creation process. These should be mocked to allow these to be run offline.

Details

	Subject	Repo	Branch	Lines +/-
	Make report page tests work offline	labs/tools/heritage	master	+85 -87

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T206148 Ensure all unit tests work offline
		Resolved		Effeietsanders	T203251 Allow report page tests to run offline

Event Timeline

Lokal_Profil created this task.Aug 31 2018, 2:00 PM

Change 456635 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Make report page tests work offline

https://gerrit.wikimedia.org/r/456635

gerritbot added a project: Patch-For-Review.Aug 31 2018, 2:02 PM

Lokal_Profil moved this task from 📥 Backlog to 🏖️ Non-WMSE on the User-LokalProfil board.Aug 31 2018, 3:27 PM

Change 456635 merged by jenkins-bot:
[labs/tools/heritage@master] Make report page tests work offline

https://gerrit.wikimedia.org/r/456635

I would have hoped the tests would run faster after this, but a time tox -e py27 still yields ~30s :-(

There are still some other tests which connect to live sites

Lokal_Profil added a project: Wiki-Loves-Monuments (2018).Sep 11 2018, 12:19 PM

Lokal_Profil moved this task from Backlog to Done - in September on the Wiki-Loves-Monuments (2018) board.

Mentioned in SAL (#wikimedia-cloud) [2018-09-13T15:33:59Z] <JeanFred> Deploy latest from Git master: ea05949, 4946df8 (T203251), f2e1368, 3664168