Page MenuHomePhabricator
Create Task
Maniphest T203259

Deprecate #mw-notification-area in favour of .mw-notification-area
Closed, ResolvedPublic
Actions

Description

The ID is unnecessary, and our style guide advises against using them: https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS

mwgrep gave no results for on-site usage, and there are only a few references in the MW codebase.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace ID selector with class selector (mw-notification-area)mediawiki/skins/MinervaNeuemaster+1 -1
Replace ID selector with class selector (mw-notification-area)mediawiki/extensions/Wikibasemaster+2 -2
Customize query in gerrit

Event Timeline

Esanders created this task.Aug 31 2018, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 3:21 PM
gerritbot subscribed.Aug 31 2018, 3:22 PM

Change 455848 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455848

gerritbot added a project: Patch-For-Review.Aug 31 2018, 3:22 PM
Esanders added a comment.Aug 31 2018, 3:22 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/455849/ (merged)

gerritbot added a comment.Aug 31 2018, 3:23 PM

Change 455847 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Wikibase@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455847

Aklapper added a project: Technical-Debt.Aug 31 2018, 3:46 PM
gerritbot added a comment.Sep 3 2018, 4:18 PM

Change 455847 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455847

gerritbot added a comment.Sep 3 2018, 4:18 PM

Change 455848 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455848

matmarex closed this task as Resolved.Sep 3 2018, 4:54 PM
matmarex assigned this task to Esanders.
matmarex subscribed.

I assume that's all.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 3 2018, 5:01 PM
Jdlrobson awarded a token.Sep 4 2018, 5:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits