Page MenuHomePhabricator

Deprecate #mw-notification-area in favour of .mw-notification-area
Closed, ResolvedPublic

Description

The ID is unnecessary, and our style guide advises against using them: https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS

mwgrep gave no results for on-site usage, and there are only a few references in the MW codebase.

Event Timeline

Esanders created this task.Aug 31 2018, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 3:21 PM

Change 455848 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455848

Change 455847 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Wikibase@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455847

Change 455847 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455847

Change 455848 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace ID selector with class selector (mw-notification-area)

https://gerrit.wikimedia.org/r/455848

matmarex closed this task as Resolved.Sep 3 2018, 4:54 PM
matmarex assigned this task to Esanders.
matmarex added a subscriber: matmarex.

I assume that's all.