Page MenuHomePhabricator

Unable to make edits from Summary Screen
Closed, ResolvedPublic1 Estimated Story Points

Description

I keep getting this error when I try to edit things on the summary screen.

image.png (112×412 px, 14 KB)

Some things like tags can be edited from the tags tab but Job Title cannot.
I cannot edit current employer, nickname, job title, tags. I think that might be it.
Partner Field works.
Also, I am using the customized summary screen for Major Gifts if that makes a difference! I believe the block these items are in was one we built for our screens.

Event Timeline

@NNichols we just found the profiles with contact id in them don't save (because it's not editable I guess). We have tried removing them from those profiles

@Eileenmcnaughton That makes sense! Thanks for figuring that out. It seems to be working for me now. I just added another block that contains only the Contact ID since like you said it's not editable.

@Eileenmcnaughton I spoke too soon. I still can't edit tags. Also, if I enter an employer on the summary screen and save The relationship then appears as both Current and Inactive at the same time.

@Eileenmcnaughton Sorry to tack on more to this task but is there a way to fix this?

image.png (233×272 px, 15 KB)

I am editing the Prospect field Next Steps from the Summary Screen and cannot seem to get it just to show me the text I inserted.

@NNichols - I want to break this down into subtasks - can you confirm these are the issues

  1. contact_id breaks a profile (already fixed for WMF by excluding & logged upstream here https://github.com/civicrm/org.civicrm.contactlayout/issues/16
  2. tags profile only works if you save with exactly one tag https://github.com/civicrm/org.civicrm.contactlayout/issues/17
  3. 'untethering employer field into a profile' doesn't edit relationships correctly (we might need to use the key relationships block here - not sure)
  4. incorrect display for fields with html in them

@Eileenmcnaughton Yes I can confirm those are each individual issues we've encountered

  1. I created a separate block for the ID to live with the contact source since these are things that do not change
  2. yes - also no biggie but we lost the ability to have color coded tags :(
  3. yes - I have also removed the current employer from the custom block we were using and am now relying on the Key relationships block - only issue is that it is not right next to the Job Title field
  4. YES

Change 461507 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Further upstream fixes for contact layout editor.

https://gerrit.wikimedia.org/r/461507

I've put up a patch of further upstream fixes that Coleman has worked on - I've copied my commit message here for visibility

Further upstream fixes for contact layout editor.

For our purposes this fixes
1) tags have lost their colour (this is from a comment not a separate issue, to test you need
to configure a tag with a colour and also have tags in your contact layour block).
2) blocks that don't work on organizations still show up on organization records but
do not work. This is an issue that hurt Elliot & I in testing but is not
hit in live since Nora has configured correctly in live.

Specific patches of interest are

https://github.com/civicrm/org.civicrm.contactlayout/commit/ef1eab79e8ed4c882149f10ad9c5ef5976ea2126
https://github.com/civicrm/org.civicrm.contactlayout/commit/d506daf5eb02d17bff5687c8b484852e44a97688

Change 461507 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Further upstream fixes for contact layout editor.

https://gerrit.wikimedia.org/r/461507

@NNichols you should have colour on your tags again now! This is the last of the contact layout issues - shall I close it?

Eileenmcnaughton set the point value for this task to 1.