As reported here, the "last use" time of PageTriage is not properly stored or accessed, which leads to inconsistent results for loading the page curation toolbar on individual page views.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Determine toolbar visibility with query param and localStorage | mediawiki/extensions/PageTriage | master | +40 -97 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Just to record a conversation I had with @kostajh, he said that he will investigate one additional idea here, but that since it is so difficult to reproduce this, and since it is not blocking reviews, we'll need to keep an eye on it and assemble more evidence over time.
Comment Actions
This is reproducible on test.wikipedia.org (credit to @Etonkovidova):
- As a logged-in user, go to https://test.wikipedia.org/wiki/Special:NewPagesFeed
- Click "Review" next to an article, verify that the toolbar appears
- Wait 4 hours
- Reload the article, toolbar appears inconsistently across page reloads
There appears to be a problem using session data for keeping track of last use (see here).
We could both simplify the code and work around this bug by using LocalStorage for keeping track of a user's last use of PageTriage. In listControlNav.js we'd want to use mw.storage.session.set( 'pagetriage-lastuse', mw.now();, then in modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolbarView.js:L128 calculate whether to show/hide the toolbar based on getting the pagetriage-lastuse value in LocalStorage.
Comment Actions
Change 458550 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] WIP: Use localStorage for tracking PageTriage last use
Comment Actions
Per discussion with @MMiller_WMF today, submitting my WIP patch for this and marking the task as stalled for now.
Also adding that per discussion with @aaron, localStorage is the preferred solution as sessions aren't meant for this kind of data any more.
Comment Actions
Change 458550 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Determine toolbar visibility with query param and localStorage
Comment Actions
@kostajh -- more detailed comments from User:Atsme are here: https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#New_Issue%3F.
Comment Actions
@MMiller_WMF thanks for that. Users will continue to experience the issue until next Thursday's deployment, because the patch above didn't make it into this week's train. If you would like, we could swat the patch so it's in production today or tomorrow. We could also ask users to verify that things are fixed in testwiki this week and wait until next week for the fix to roll out with the next train.
Comment Actions
@kostajh -- I think it is fine for users to wait until next Thursday. I will just give them that update. And I kind of think it will cause additional confusion to test in Test Wiki because the issue is sort of silent and intermittent, so it will be hard to tell if it is caused by the change in environment?
Comment Actions
Waiting is fine by me, probably good to tell the users that a fix is coming next week then. It is possible to reproduce the bug (see here) if any users want to try.