|mediawiki/extensions/PageTriage||master||+40 -97||Determine toolbar visibility with query param and localStorage|
This is reproducible on test.wikipedia.org (credit to @Etonkovidova):
- As a logged-in user, go to https://test.wikipedia.org/wiki/Special:NewPagesFeed
- Click "Review" next to an article, verify that the toolbar appears
- Wait 4 hours
- Reload the article, toolbar appears inconsistently across page reloads
There appears to be a problem using session data for keeping track of last use (see here).
We could both simplify the code and work around this bug by using LocalStorage for keeping track of a user's last use of PageTriage. In listControlNav.js we'd want to use mw.storage.session.set( 'pagetriage-lastuse', mw.now();, then in modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolbarView.js:L128 calculate whether to show/hide the toolbar based on getting the pagetriage-lastuse value in LocalStorage.
@MMiller_WMF thanks for that. Users will continue to experience the issue until next Thursday's deployment, because the patch above didn't make it into this week's train. If you would like, we could swat the patch so it's in production today or tomorrow. We could also ask users to verify that things are fixed in testwiki this week and wait until next week for the fix to roll out with the next train.
@kostajh -- I think it is fine for users to wait until next Thursday. I will just give them that update. And I kind of think it will cause additional confusion to test in Test Wiki because the issue is sort of silent and intermittent, so it will be hard to tell if it is caused by the change in environment?