Page MenuHomePhabricator

Don't assume commands exist when building CommandHelpDialog
Closed, ResolvedPublic

Description

This isn't a problem in a normal setup, but if a command was unregistered, it could cause the dialog to crash.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (a72861b26)
VisualEditor/VisualEditor : masterCleanup: Don't assume commands exist when building list
mediawiki/extensions/VisualEditor : masterDon't assume commandGroup has a demote property set

Event Timeline

Esanders created this task.Aug 31 2018, 9:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 9:20 PM

Change 456751 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't assume commandGroup has a demote property set

https://gerrit.wikimedia.org/r/456751

Change 456749 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Cleanup: Don't assume commands exist when building list

https://gerrit.wikimedia.org/r/456749

Change 456751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't assume commandGroup has a demote property set

https://gerrit.wikimedia.org/r/456751

Change 456749 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Cleanup: Don't assume commands exist when building list

https://gerrit.wikimedia.org/r/456749

Change 457898 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a72861b26)

https://gerrit.wikimedia.org/r/457898

Change 457898 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a72861b26)

https://gerrit.wikimedia.org/r/457898

Deskana closed this task as Resolved.Sep 27 2018, 12:29 PM
Deskana triaged this task as Low priority.