Maniphest T203282

Don't assume commands exist when building CommandHelpDialog
Closed, ResolvedPublic
Actions

Description

This isn't a problem in a normal setup, but if a command was unregistered, it could cause the dialog to crash.

Details

Related Gerrit Patches:

mediawiki/extensions/VisualEditor : master	Update VE core submodule to master (a72861b26)
VisualEditor/VisualEditor : master	Cleanup: Don't assume commands exist when building list
mediawiki/extensions/VisualEditor : master	Don't assume commandGroup has a demote property set

Related Objects

Mentioned Here: rGVEDa72861b26930: Merge "ve.ce.Surface: Make a check for pasted "important elements" faster"

Event Timeline

Esanders created this task.Aug 31 2018, 9:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 9:20 PM

Change 456751 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't assume commandGroup has a demote property set

https://gerrit.wikimedia.org/r/456751

Change 456749 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Cleanup: Don't assume commands exist when building list

https://gerrit.wikimedia.org/r/456749

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Aug 31 2018, 9:30 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 456751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't assume commandGroup has a demote property set

https://gerrit.wikimedia.org/r/456751

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 1 2018, 12:01 AM

Change 456749 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Cleanup: Don't assume commands exist when building list

https://gerrit.wikimedia.org/r/456749

Change 457898 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a72861b26)

https://gerrit.wikimedia.org/r/457898

Change 457898 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a72861b26)

https://gerrit.wikimedia.org/r/457898

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 4 2018, 2:00 PM

Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.Sep 4 2018, 3:27 PM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.

Deskana closed this task as Resolved.Sep 27 2018, 12:29 PM

Deskana triaged this task as Low priority.