Maniphest T203308

phan-taint-check sometimes can't tell that the third arg to a tag hook is a Parser object unless there is a type hint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Sep 1 2018, 8:54 AM

Description

In particular see I18nTags f0388c9b03f9

It seems like since nothing actually calls the parser tag hook, phan doesn't have info on what the args are unless there are type hints. This can result in it not knowing what calls to $parser->recursiveTagParse() do.

Details

	Subject	Repo	Branch	Lines +/-
	Make parser hooks work properly even without type hints	mediawiki/tools/phan/SecurityCheckPlugin	master	+59 -6

Customize query in gerrit

Related Objects

Mentioned Here: rEINTf0388c9b03f9: Merge "Build: update versions"

Event Timeline

Bawolff created this task.Sep 1 2018, 8:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2018, 8:54 AM

Bawolff added a project: phan-taint-check-plugin.Sep 1 2018, 8:54 AM

Bawolff moved this task from Backlog to Plugin itself on the phan-taint-check-plugin board.Sep 4 2018, 9:29 AM

Change 457953 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Make parser hooks work properly even without type hints

https://gerrit.wikimedia.org/r/457953

gerritbot added a project: Patch-For-Review.Sep 4 2018, 5:37 PM

Change 457953 merged by jenkins-bot:
[mediawiki/tools/phan/SecurityCheckPlugin@master] Make parser hooks work properly even without type hints

https://gerrit.wikimedia.org/r/457953

Bawolff closed this task as Resolved.Sep 6 2018, 12:12 AM

Bawolff claimed this task.

sbassett moved this task from Plugin itself to Done on the phan-taint-check-plugin board.Oct 15 2019, 6:59 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 7:12 PM

sbassett triaged this task as Medium priority.Oct 15 2019, 7:23 PM