Maniphest T203358

redirect.py does not count saved pages
Closed, ResolvedPublic
Actions

Description

C:\pwb\GIT\core>pwb.py redirect do -moves -lang:fr
Retrieving all moved pages...
................................................................................
....

>>> Discussion utilisateur:Grigory Agabaian <<<
   Links to: [[Discussion utilisateur:Grigory Agabalian]].
   Links to: [[Discussion utilisateur:Grigory05]].
@@ -1 +1 @@
- #REDIRECTION [[Discussion utilisateur:Grigory Agabalian]]
+ #REDIRECTION [[Discussion utilisateur:Grigory05]]

Do you want to accept the changes? ([y]es, [N]o, [a]ll, [q]uit): y
Page [[Discussion utilisateur:Grigory Agabaian]] saved
...

>>> Utilisateur:Clgab/Brouillon <<<
   Links to: [[Royaume de Naples napoléonien (1806-1815)]].
   Links to: [[Royaume de Naples (1806-1815)]].
@@ -1 +1 @@
- #REDIRECTION [[Royaume de Naples napoléonien (1806-1815)]]
+ #REDIRECTION [[Royaume de Naples (1806-1815)]]

Do you want to accept the changes? ([y]es, [N]o, [a]ll, [q]uit): q

User quit RedirectRobot bot run...

1 pages read
0 pages written
Execution time: 177 seconds
Read operation time: 177 seconds
Script terminated successfully.

C:\pwb\GIT\core>

Details

	Project	Branch	Lines +/-	Subject
	pywikibot/core	master	+11 -44	[IMPR] Adjust BaseBot._savecounter for RedirectRobot

Customize query in gerrit

Related Objects

Mentioned Here: T196851: Evaluate BaseBot class usage across scripts
T147178: Edit counter gives wrong result in replace.py

Event Timeline

Xqt created this task.Sep 2 2018, 4:38 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 2 2018, 4:38 PM

Isn't this the same like T147178 caused by async?

Framawiki added a subscriber: Framawiki.Sep 2 2018, 5:10 PM

In T203358#4552026, @Dvorapa wrote:

Isn't this the same like T147178 caused by async?

No it's due to the use of Page.save() instead of BaseBot.userPut()

Xqt triaged this task as Low priority.Sep 2 2018, 5:19 PM

Also similar to T196851 (add no. of pages changed to scripts)

In T203358#4552118, @Dvorapa wrote:

Also similar to T196851 (add no. of pages changed to scripts)

A bit. Currently redirect.py is not fully compliant to BaseBot usage.

Change 456999 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Adjust BaseBot._savecounter for RedirectRobot

https://gerrit.wikimedia.org/r/456999

gerritbot added a project: Patch-For-Review.Sep 3 2018, 6:11 AM

Xqt moved this task from Backlog to Needs Review on the Pywikibot board.Sep 5 2018, 1:44 PM

Change 456999 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Adjust BaseBot._savecounter for RedirectRobot