Page MenuHomePhabricator

Fix npm eslint style warnings
Closed, ResolvedPublic

Description

While testing this patch (jenkinks log) I've detected the following:

21:58:25 Running "eslint:all" (eslint) task
21:58:30 
21:58:30 /workspace/src/extensions/AbuseFilter/modules/ext.abuseFilter.edit.js
21:58:30   261:1  warning  Line 261 exceeds the maximum line length of 100  max-len
21:58:30   395:1  warning  Line 395 exceeds the maximum line length of 100  max-len
21:58:30   396:1  warning  Line 396 exceeds the maximum line length of 100  max-len
21:58:30 
21:58:30 /workspace/src/extensions/AbuseFilter/modules/ext.abuseFilter.examine.js
21:58:30   55:1  warning  Line 55 exceeds the maximum line length of 100  max-len
21:58:30 
21:58:30 ✖ 4 problems (0 errors, 4 warnings)

I'd say it'd be nice to get those fixed :-)

Thank you.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2018, 9:47 PM
MarcoAurelio updated the task description. (Show Details)Sep 2 2018, 10:08 PM

Change 457377 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Break long lines in JS code

https://gerrit.wikimedia.org/r/457377

Daimona claimed this task.Sep 3 2018, 8:50 AM

Change 457377 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Break long lines in JS code

https://gerrit.wikimedia.org/r/457377

Daimona closed this task as Resolved.Sep 3 2018, 5:13 PM