Page MenuHomePhabricator
Create Task
Maniphest T203412

Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

This particular QUnit test failure has been causing builds to fail in MediaWiki core and other extensions.

qunit
FAILED TESTS (1/1):

ve.ui.MWWikitextStringTransferHandler (Cite)
  ✖ convert

  Error: Pending AJAX requests: 1 (active: 1)

I'm unsure as to what code initiates the faulty/untracked Ajax request, but it's likely either the above test itself or a test shortly before it.

The debug log from the above Jenkins builds shows the last HTTP fetch to be for a url /null which seems like a bug, but might be unrelated.

00:11:12.519 03 09 2018 18:46:49.694:DEBUG [middleware:source-files]: Requesting /null /
00:11:12.520 03 09 2018 18:46:49.695:DEBUG [middleware:source-files]: Fetching /null
00:11:12.521 03 09 2018 18:46:49.696:DEBUG [proxy]: proxying request - /null to 127.0.0.1:9412

Details

SubjectRepoBranchLines +/-
Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"mediawiki/extensions/VisualEditormaster+0 -83
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Sep 3 2018, 7:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2018, 7:05 PM
Krinkle triaged this task as Unbreak Now! priority.Sep 3 2018, 7:05 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 3 2018, 7:05 PM
Krinkle renamed this task from QUnit test ve.ui.MWWikitextStringTransferHandler fails with "pending AJAX requests" to Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests".Sep 3 2018, 7:05 PM
Krinkle updated the task description. (Show Details)
matmarex merged a task: T203411: ve.ui.MWWikitextStringTransferHandler browser test breaks on unrelated patches.Sep 3 2018, 8:19 PM
matmarex added a subscriber: Tgr.
matmarex subscribed.Sep 3 2018, 10:37 PM

I can reproduce this semi-consistently after setting a custom network throttling profile in Chromium debugger to delay all requests by 2000 ms.

After experimenting a bunch I'm pretty sure this is caused by the new test added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/456629. Constructing a ve.init.mw.DesktopArticleTarget eventually calls setEditorPreference() (private function in ve.init.mw.DesktopArticleTarget.init.js), which makes some API requests to save user options, and we don't wait for them.

gerritbot subscribed.Sep 3 2018, 10:39 PM

Change 457699 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"

https://gerrit.wikimedia.org/r/457699

gerritbot added a project: Patch-For-Review.Sep 3 2018, 10:39 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 3 2018, 10:42 PM

@Krinkle Is there some convenient way to view failure rates and see if reverting that fixed the issue?

gerritbot added a comment.Sep 3 2018, 10:56 PM

Change 457699 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"

https://gerrit.wikimedia.org/r/457699

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 3 2018, 11:00 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Sep 4 2018, 1:32 PM
Krinkle added a comment.Sep 4 2018, 4:16 PM

@matmarex The trend subpages of each Jenkins job might help, e.g. https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-hhvm-docker/buildTimeTrend. Although keep in mind that it's normal for failures to show up given they (also) run against unmerged patch sets that may have genuine failures.

Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Sep 4 2018, 4:16 PM
Ryasmeen subscribed.Sep 4 2018, 9:23 PM

I don't think there is anything for me to verify here. Moving it to "Done" column on VisualEditor workboard.

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 4 2018, 9:24 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 4 2018, 10:55 PM
matmarex closed this task as Resolved.Sep 12 2018, 9:33 PM
matmarex claimed this task.

There is really no reason for this to stay open. I fixed it a week ago.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 12 2018, 9:33 PM
matmarex added a comment.Sep 12 2018, 9:34 PM

Ed worked out how to prevent this problem, and I just merged his commit that re-adds the test, hopefully without any more spurious failures: https://gerrit.wikimedia.org/r/457884

Liuxinyu970226 unsubscribed.Sep 20 2018, 4:32 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Krinkle mentioned this in T247278: "Pending AJAX requests" error from VisualEditor tests.Mar 10 2020, 1:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL