https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php%24&repos= lists some back-compatible code that was written for the PHP 5.3 era.
This is no longer needed because all MediaWiki versions that are nowadays supported require at least PHP version 7.
Go through that output, find two specific instances of such code, and clean them up in a patch!
Example: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457812
Mentors: (none)
Search queries:
Might want to consider opening a new task or tweaking this one for all work arounds for PHP < 7 since all supported versions now require at least 7.0.
@vaibhavsingh: Hi, do you have specific questions? See the task description for information. If that information is not sufficient, then please elaborate what exactly is not sufficient and why. Thanks! :)
@Aklapper in the link https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php&repos= the first mention in (includes/libs/ArrayUtils.php )theres there is information regarding benchmarking in php .but the effeciency of hash and md5 remains pretty same for all php >5.2 specially for small strings so what we need to do in here???
@Legoktm 's name in the mentor section is misleading. They haven't explicitly agreed to mentor this task for GCI2019, not yet.
@vaibhavsingh: The task description says that this is about "some back-compatible code".
includes/libs/ArrayUtils.php is not code. It is a comment only. So there is nothing to do in that file.
can we provide a late static binding method by changing all of self keyword to static in "includes/PFun_Caller.php"???
Prior to PHP 5.4, closures didn't have access to $this, so it had to be passed in explicitly. See https://www.php.net/manual/en/functions.anonymous.php.
I'm going to be making some of the changes suggested by this task today. Let me know if we're going to clash on anything.
Change 592450 had a related patch set uploaded (by Bobulous; owner: Bobulous):
[mediawiki/core@master] Replace dirname usage with PHP 7 equivalents.
Change 592484 had a related patch set uploaded (by Bobulous; owner: Bobulous):
[mediawiki/core@master] Add comment to say PHP 4 only until version check.
Change 592484 abandoned by Bobulous:
Add comment to say PHP 4 only until version check.
Reason:
Abandoning due to lack of review or other feedback.
Change 735640 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):
[mediawiki/extensions/CentralAuth@master] Clean up compatibility with PHP 5
Change 735640 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Clean up compatibility with PHP 5