Maniphest T203425

Clean up back-compatible code from the PHP 5.3 era
Open, Needs TriagePublic
Actions

Description

https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php%24&repos= lists some back-compatible code that was written for the PHP 5.3 era.
This is no longer needed because all MediaWiki versions that are nowadays supported require at least PHP version 7.

Go through that output, find two specific instances of such code, and clean them up in a patch!

Example: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457812

Mentors: (none)

Search queries:

[[ https://codesearch.wmflabs.org/search/?q=%5C%24(self%7Cthat)%20%3D%20%5C%24this%3B&i=nope&files=%5C.php%24&repos= | Implicit binding of $this in closures ]]
Mentions of old PHP versions in code
[[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*callable%20*%5C*%5C%2F&i=nope&files=%5C.php%24&repos= | callable type hint ]]
Class constant visibility
Negative indexing

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+37 -3	Add comment to say PHP 4 only until version check.
	mediawiki/core	master	+5 -7	Replace dirname usage with PHP 7 equivalents.

Customize query in gerrit

Event Timeline

Legoktm created this task.Sep 4 2018, 5:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2018, 5:16 AM

Aklapper added a project: Google-Code-in-2018.Sep 7 2018, 11:04 AM

https://codein.withgoogle.com/tasks/6397285849104384/ but mentors needed.

Platonides added a subscriber: Platonides.Oct 7 2018, 10:12 PM

In T203425#4647858, @Aklapper wrote:

https://codein.withgoogle.com/tasks/6397285849104384/ but mentors needed.

Sorry, I forgot to explicitly volunteer to mentor this :)

Legoktm updated the task description. (Show Details)Oct 8 2018, 2:24 AM

Izno updated the task description. (Show Details)Oct 8 2018, 2:40 AM

Thanks!

MGChecker added a subscriber: MGChecker.Oct 9 2018, 7:20 AM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Oct 21 2018, 2:10 AM

Should be ok and for Google-Code-in-2019.

In T203425#4648502, @Legoktm wrote:

In T203425#4647858, @Aklapper wrote:

https://codein.withgoogle.com/tasks/6397285849104384/ but mentors needed.

Sorry, I forgot to explicitly volunteer to mentor this :)

Would you be willing to mentor this once again? :-)

Might want to consider opening a new task or tweaking this one for all work arounds for PHP < 7 since all supported versions now require at least 7.0.

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2019 board.Nov 25 2019, 3:28 AM

matej_suchanek updated the task description. (Show Details)Jan 3 2020, 6:38 PM

can i as a beginner work on this task?

Hi @vaibhavsingh and welcome! Yes, this task is marked as a good first task.

@Aklapper can you please breif me a bit more about this task ????

@vaibhavsingh: Hi, do you have specific questions? See the task description for information. If that information is not sufficient, then please elaborate what exactly is not sufficient and why. Thanks! :)

@Aklapper in the link https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php&repos= the first mention in (includes/libs/ArrayUtils.php )theres there is information regarding benchmarking in php .but the effeciency of hash and md5 remains pretty same for all php >5.2 specially for small strings so what we need to do in here???

@Legoktm 's name in the mentor section is misleading. They haven't explicitly agreed to mentor this task for GCI2019, not yet.

This was available in Google-Code-in-2018 hence re-adding Google-Code-in-2018 :)

@vaibhavsingh: The task description says that this is about "some back-compatible code".
includes/libs/ArrayUtils.php is not code. It is a comment only. So there is nothing to do in that file.

can we provide a late static binding method by changing all of self keyword to static in "includes/PFun_Caller.php"???

matej_suchanek updated the task description. (Show Details)Jan 11 2020, 10:15 AM

Izno updated the task description. (Show Details)Jan 11 2020, 3:25 PM

What does implicit binding of $this in closures means???

In T203425#5798905, @vaibhavsingh wrote:

What does implicit binding of $this in closures means???

Prior to PHP 5.4, closures didn't have access to $this, so it had to be passed in explicitly. See https://www.php.net/manual/en/functions.anonymous.php.

matej_suchanek updated the task description. (Show Details)Jan 18 2020, 11:42 AM

I'm going to be making some of the changes suggested by this task today. Let me know if we're going to clash on anything.

Change 592450 had a related patch set uploaded (by Bobulous; owner: Bobulous):
[mediawiki/core@master] Replace dirname usage with PHP 7 equivalents.

https://gerrit.wikimedia.org/r/592450

gerritbot added a project: Patch-For-Review.Apr 25 2020, 1:41 PM

Change 592450 abandoned by Bobulous:
Replace dirname usage with PHP 7 equivalents.

https://gerrit.wikimedia.org/r/592450

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2020, 4:10 PM

Change 592484 had a related patch set uploaded (by Bobulous; owner: Bobulous):
[mediawiki/core@master] Add comment to say PHP 4 only until version check.

https://gerrit.wikimedia.org/r/592484

gerritbot added a project: Patch-For-Review.Apr 26 2020, 1:34 PM

Change 592484 abandoned by Bobulous:
Add comment to say PHP 4 only until version check.

Reason:
Abandoning due to lack of review or other feedback.

https://gerrit.wikimedia.org/r/592484

Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 7:10 PM

Bobulous removed Bobulous as the assignee of this task.May 12 2020, 7:20 PM

Bobulous added a subscriber: Bobulous.

Bobulous removed a subscriber: Bobulous.May 12 2020, 7:44 PM