Page MenuHomePhabricator
Create Task
Maniphest T203474

Fix command help dialog in mobile visual editor on MinervaNeue
Closed, ResolvedPublic
Actions

Assigned To
Tchanders
Authored By
Tchanders
Sep 4 2018, 3:29 PM
Tags
Referenced Files
F25677896: image.png
Sep 6 2018, 1:23 PM
F25614007: command_help_dialog.png
Sep 4 2018, 3:29 PM
Subscribers
Aklapper
Deskana
Esanders
gerritbot
• iamjessklein
matmarex
Ryasmeen
View All 9 Subscribers

Description

The command help dialog uses three columns, even on a narrow screen:

command_help_dialog.png (641×360 px, 80 KB)

The styling is also broken (weird extra borders around every item).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e4ca18ac3)mediawiki/extensions/VisualEditormaster+1 -1
Make columns responsive in visual editor command help dialogVisualEditor/VisualEditormaster+3 -4
Scope styling of kbd/samp/code/pre to content areasmediawiki/skins/MinervaNeuemaster+44 -44
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders triaged this task as Medium priority.Sep 4 2018, 3:29 PM
Tchanders created this task.
Tchanders removed a subtask: T203476: Improve diff dialog for mobile visual editor.Sep 4 2018, 3:39 PM
matmarex updated the task description. (Show Details)Sep 4 2018, 3:56 PM
gerritbot added a subscriber: gerritbot.Sep 4 2018, 3:56 PM

Change 456894 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Scope styling of kbd/samp/code/pre to content areas

https://gerrit.wikimedia.org/r/456894

gerritbot added a project: Patch-For-Review.Sep 4 2018, 3:56 PM
gerritbot added a comment.Sep 4 2018, 9:33 PM

Change 456894 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Scope styling of kbd/samp/code/pre to content areas

https://gerrit.wikimedia.org/r/456894

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Mobile; removed Patch-For-Review.Sep 4 2018, 9:44 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 4 2018, 10:00 PM
gerritbot added a comment.Sep 5 2018, 5:50 PM

Change 458250 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Make columns responsive in visual editor command help dialog

https://gerrit.wikimedia.org/r/458250

gerritbot added a project: Patch-For-Review.Sep 5 2018, 5:50 PM
Tchanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 6 2018, 12:15 PM
Esanders added a comment.Sep 6 2018, 1:23 PM

After:

image.png (694×404 px, 47 KB)

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 6 2018, 1:23 PM
gerritbot added a comment.Sep 6 2018, 1:26 PM

Change 458250 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make columns responsive in visual editor command help dialog

https://gerrit.wikimedia.org/r/458250

Jdforrester-WMF removed a project: Patch-For-Review.Sep 6 2018, 3:17 PM
gerritbot added a comment.Sep 6 2018, 3:27 PM

Change 458275 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4ca18ac3)

https://gerrit.wikimedia.org/r/458275

gerritbot added a project: Patch-For-Review.Sep 6 2018, 3:27 PM
gerritbot added a comment.Sep 6 2018, 4:11 PM

Change 458275 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4ca18ac3)

https://gerrit.wikimedia.org/r/458275

Jdforrester-WMF removed a project: Patch-For-Review.Sep 6 2018, 4:58 PM
Ryasmeen added a subscriber: Ryasmeen.Sep 6 2018, 9:03 PM

@Tchanders: I can't find this dialog on Mobile VE to verify it. Could you help me find this? :)

Ryasmeen added a comment.Sep 6 2018, 9:10 PM
In T203474#4564375, @Ryasmeen wrote:

@Tchanders: I can't find this dialog on Mobile VE to verify it. Could you help me find this? :)

Ah it was on MinervaNeue skin. Found it, nevermind :)

Ryasmeen renamed this task from Fix command help dialog in mobile visual editor to Fix command help dialog in mobile visual editor on MinervaNeue.Sep 6 2018, 9:10 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Deskana closed this task as Resolved.Sep 28 2018, 3:00 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 28 2018, 3:00 PM
• iamjessklein mentioned this in T202575: Epic: Be more consistent about dialog availability in mobile visual editor.Oct 8 2018, 1:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL