Page MenuHomePhabricator

Improve diff dialog for mobile visual editor
Closed, ResolvedPublic

Description

Diffs are displayed differently according to whether there are only text changes:


or whether there are attribute changes:

In the latter situation, on mobile, the description column takes up so much space that it's difficult to see the document context. (NB in this example, the unchanged paragraph is very short. If it were much longer, it wouldn't be possible to see any changes without scrolling down.)

Event Timeline

A simple fix would be to make the sidebar narrower for smaller screen sizes.

Desktop:

Mobile:

Change 463690 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Make visual diff dialog sidebar narrower on narrow screens

https://gerrit.wikimedia.org/r/463690

Change 463690 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make visual diff dialog sidebar narrower on narrow screens

https://gerrit.wikimedia.org/r/463690

The dialog has been improved so this bug is probably closeable, but we should file a follow-up to come up with a better layout that doesn't use narrow columns.

Change 464449 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (527d45433)

https://gerrit.wikimedia.org/r/464449

Change 464449 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (527d45433)

https://gerrit.wikimedia.org/r/464449

iamjessklein added a comment.EditedOct 8 2018, 4:35 PM

The dialog has been improved so this bug is probably closeable, but we should file a follow-up to come up with a better layout that doesn't use narrow columns.

+1 , this should be addressed in T206463

Adding a comment to workaround an issue with phab to be able to edit this task.

Deskana closed this task as Resolved.Oct 11 2018, 2:59 PM

Hooray for iterative improvements!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2018, 2:59 PM