Page MenuHomePhabricator

Improve diff dialog for mobile visual editor
Closed, ResolvedPublic

Description

Diffs are displayed differently according to whether there are only text changes:

Screen Shot 2018-09-04 at 16.33.18.png (668×374 px, 46 KB)

or whether there are attribute changes:
diff_dialog.png (664×372 px, 56 KB)

In the latter situation, on mobile, the description column takes up so much space that it's difficult to see the document context. (NB in this example, the unchanged paragraph is very short. If it were much longer, it wouldn't be possible to see any changes without scrolling down.)

Event Timeline

A simple fix would be to make the sidebar narrower for smaller screen sizes.

Desktop:

image.png (647×909 px, 241 KB)

Mobile:

image.png (570×320 px, 60 KB)
image.png (567×322 px, 124 KB)

Change 463690 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Make visual diff dialog sidebar narrower on narrow screens

https://gerrit.wikimedia.org/r/463690

Change 463690 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make visual diff dialog sidebar narrower on narrow screens

https://gerrit.wikimedia.org/r/463690

The dialog has been improved so this bug is probably closeable, but we should file a follow-up to come up with a better layout that doesn't use narrow columns.

Change 464449 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (527d45433)

https://gerrit.wikimedia.org/r/464449

Change 464449 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (527d45433)

https://gerrit.wikimedia.org/r/464449

The dialog has been improved so this bug is probably closeable, but we should file a follow-up to come up with a better layout that doesn't use narrow columns.

+1 , this should be addressed in T206463

Adding a comment to workaround an issue with phab to be able to edit this task.

Hooray for iterative improvements!