Page MenuHomePhabricator

Implement visual changes on CleanChanges for SDC
Open, Needs TriagePublic

Description

Goal
Update Visual design for CleanChanges UI to match design guidelines and wmf product aesthetic

Design
https://wikimedia.invisionapp.com/share/EZIQWA3SWNQ#/screens/297308715

Tracking card
T201431

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptSep 4 2018, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nirzar assigned this task to Prtksxna.Sep 4 2018, 11:37 PM
Nirzar updated the task description. (Show Details)Sep 4 2018, 11:42 PM

Hey @Ramsey-WMF! I have installed the CleanChanges extension on my local mediawiki. Could you point me to the steps to follow to see it in action?

Hey @Ramsey-WMF! I have installed the CleanChanges extension on my local mediawiki. Could you point me to the steps to follow to see it in action?

I refer this to the expertise of @MarkTraceur :)

@Prtksxna I believe it should be as simple as making multiple (maybe small) changes to a single page, which should trigger the (2 changes) behavior at least. I haven't worked with this extension in the past, but that's what I'd guess based on the extension page...

@Prtksxna I believe it should be as simple as making multiple (maybe small) changes to a single page, which should trigger the (2 changes) behavior at least. I haven't worked with this extension in the past, but that's what I'd guess based on the extension page...

Doing that is triggering the enhanced change list that collapses and expands, but I don't think it is CleanChanges. I do see it on my Special:Version though.

Any idea what I am doing wrong?


From the description:

The new design removed the space between the arrow and the timestamp which was being used to show flags. When a flag is absent it leaves a space so that users can reliably find it at the same spot every time, I suppose they are using a monospace font for this reason. For example:

...
.N.
..m
...
..m

@Nirzar @Ramsey-WMF, the design moves the flags after the timestamp, removing this functionality, is that ok?

the design moves the flags after the timestamp, removing this functionality, is that ok?

It's ok for me :) (sorry for the delay)