Page MenuHomePhabricator

Mobile VE: Show virtual keyboard when a dialog is closed without any edit
Closed, ResolvedPublic

Description

Reactivate the surface after a dialog is closed without adding anything, like pressing back on link inspector dialog/Citation dialog.

Event Timeline

When you say "reactivate" you mean focus the surface and bring up the keyboard? Can you check this on beta labs, because I think it's working for me?

When you say "reactivate" you mean focus the surface and bring up the keyboard? Can you check this on beta labs, because I think it's working for me?

Yeah that's what I meant. Not working for me though on Beta cluster on iOS Safari and Chrome.

So the steps I followed are:

  1. Open mobile VE
  2. Open link inspector.
  3. Dont add anything just tap on back "<" button

It gets me back to the main surface but there is no keyboard unless you tap somewhere.

Esanders renamed this task from Mobile VE: Reactivate the surface when a dialog is closed without any edit to Mobile VE: Show virtual keyboard when a dialog is closed without any edit.Sep 6 2018, 11:51 AM
Esanders updated the task description. (Show Details)

Looks like we are re-activating the surface, but due to the nature of dialog processes it doesn't happen in the same event cycle as the user click event. Chrome/Safari Mobile only show the keyboard the focus/setRange call happens during a user-triggered event cycle (https://github.com/jquery/jquery-mobile/issues/3016)

Change 458488 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Re-activate surface during event cycle

https://gerrit.wikimedia.org/r/458488

Change 458488 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Re-activate surface during event cycle

https://gerrit.wikimedia.org/r/458488

Change 458836 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f7b958957)

https://gerrit.wikimedia.org/r/458836

Change 458836 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f7b958957)

https://gerrit.wikimedia.org/r/458836

Deskana triaged this task as Medium priority.