Page MenuHomePhabricator

Use default framed buttons in the RevisionSlider expand/collaps bar
Open, Needs TriagePublic

Description

I take this request from @Esanders appoach in T194613#4213027 to continue the discussion here:

You may want reduce the amount of OOUI overrides to prevent future regressions (and provide better skin support).

I would recommend having the pin and collapse buttons as simple icon-only buttons (right-aligned, instead of absolutely positioned), instead of the current nested buttons.

The ability to expand the toolbar by clicking on the label (or the space either side of it) can be re-added using a click handler to trigger the expand/collapse button, a bit how field labels can trigger checkboxes.

image.png (253×827 px, 9 KB)

Event Timeline

WMDE-Fisch added a subscriber: Volker_E.

Copied the responses by @Volker_E and @Esanders

You may want reduce the amount of OOUI overrides to prevent future regressions (and provide better skin support).

I would recommend having the pin and collapse buttons as simple icon-only buttons (right-aligned, instead of absolutely positioned), instead of the current nested buttons.

The ability to expand the toolbar by clicking on the label (or the space either side of it) can be re-added using a click handler to trigger the expand/collapse button, a bit how field labels can trigger checkboxes.

image.png (253×827 px, 9 KB)

Seems reasonable but would clearly go for frameless buttons when updating this.

@Volker_E: The problem is that the push pin is a ToggleWidget (ToggleButtonWidget) which doesn't have a frameless mode. Currently it is implemented by overriding the CSS, but I think sticking to standard widgets would be preferable.

The ticket tittle looks

Use default framed buttons in the RevisionSlider expand/collaps bar

As discussed in the ticket T201673#4496650 RevisionSlider currently doesn't have collaps icon.

The ticket tittle looks

Use default framed buttons in the RevisionSlider expand/collaps bar

As discussed in the ticket T201673#4496650 RevisionSlider currently doesn't have collaps icon.

Valid note but the title was more meant to describe the thing we're talking about and in that regard the bar is used to expand and collapse the slider ;-).

The "root" of the problem seems to be that the frameless buttons can not be toggled. If there is no particular reason against this it seems to be the most sustainable to add toggle mode to the frameless button class (or however OOUI calls "class"/"template"…). If that is not possible for us, I would leave it as it is.

It might be more of a PM decision, actually: Change it now to the standard and reduce maintanance while paying with a less good UX or vice versa?

Swathi-0901 removed Swathi-0901 as the assignee of this task.
Swathi-0901 added a subscriber: Swathi-0901.

Just to repeat my take from the original task, I'm against putting an interaction element with visual appearance of a framed button there.
The current treatment/look of the items is good IMHO and should stay the same, even with a different technical implementation. The technical concern on nested buttons by @Esanders remains.