Maniphest T203574

[BUG] Status bar icons are not visible on API<23 on app nav prototypes
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	RHo
	Sep 5 2018, 2:57 PM

Description

This was picked up in user testing in Android OS 5.1.1:

Actual:

Status bar bug - prototype A - Screenshot_2018-08-31-21-52-29.png (1×785 px, 270 KB)

Expected:
Add tint to status bar for Android <23 so light icons can be visible

Details

	Subject	Repo	Branch	Lines +/-
	Fix: Status bar icons are not visible on API<23	apps/android/wikipedia	master	+31 -17
	Fix: Status bar icons are not visible on API<23	apps/android/wikipedia	master	+17 -11

Customize query in gerrit

Related Objects

Mentioned In: T203975: Test prototype A code with lower versions of api

Event Timeline

RHo created this task.Sep 5 2018, 2:57 PM

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme). · View Herald TranscriptSep 5 2018, 2:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog.Sep 5 2018, 4:01 PM

RHo renamed this task from [BUG] Status bar icons are not visible on API<19 on app nav prototypes to [BUG] Status bar icons are not visible on API<23 on app nav prototypes.Sep 5 2018, 4:33 PM

RHo updated the task description. (Show Details)

• Charlotte edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme).Sep 5 2018, 4:37 PM

cooltey claimed this task.Sep 14 2018, 11:25 PM

cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

Change 461010 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Fix: Status bar icons are not visible on API<23

https://gerrit.wikimedia.org/r/461010

gerritbot added a project: Patch-For-Review.Sep 18 2018, 12:02 AM

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Sep 19 2018, 12:50 AM

RHo mentioned this in T203975: Test prototype A code with lower versions of api.Sep 19 2018, 2:18 PM

Change 463158 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Status bar icons are not visible on API<23

https://gerrit.wikimedia.org/r/463158

Change 461010 abandoned by Cooltey:
Fix: Status bar icons are not visible on API<23

Reason:
Too many conflicts

https://gerrit.wikimedia.org/r/461010

Change 463158 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Status bar icons are not visible on API<23

https://gerrit.wikimedia.org/r/463158

cooltey moved this task from Code Review to Design signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 9 2018, 4:54 PM

cmadeo moved this task from Design signoff to Ready for signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 11 2018, 2:26 PM

Dbrant closed this task as Resolved.Nov 1 2018, 5:18 PM

	F25666755: Status bar bug - prototype A - Screenshot_2018-08-31-21-52-29.png
	Sep 5 2018, 2:57 PM

[BUG] Status bar icons are not visible on API<23 on app nav prototypesClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

[BUG] Status bar icons are not visible on API<23 on app nav prototypes
Closed, ResolvedPublicBUG REPORT
Actions