Page MenuHomePhabricator
Create Task
Maniphest T203577

ErrorException from line 116 of /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/StudentPager.php: PHP Notice: Undefined variable: retValue
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Noticing this in 1.32.0-wmf.20:

#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/StudentPager.php(116): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/EPPager.php(466): EducationProgram\StudentPager->getFormattedValue(string, NULL)
#2 /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/EPPager.php(114): EducationProgram\EPPager->formatValue(string, NULL)
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/pager/IndexPager.php(445): EducationProgram\EPPager->formatRow(stdClass)
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/pager/TablePager.php(69): IndexPager->getBody()
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/rows/Student.php(33): TablePager->getBody()
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/cache/CacheHelper.php(297): EducationProgram\Student::getPager(RequestContext)
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/specials/SpecialCachedPage.php(148): CacheHelper->getCachedValue(string, array, NULL)
#8 /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/specials/SpecialStudents.php(33): SpecialCachedPage->addCachedHTML(string, RequestContext)
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPage.php(569): EducationProgram\SpecialStudents->execute(NULL)
#10 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(868): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(525): MediaWiki->main()
#14 /srv/mediawiki/php-1.32.0-wmf.20/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}

Details

SubjectRepoBranchLines +/-
StudentPager: Ensure $retValue exists in all code pathsmediawiki/extensions/EducationProgramwmf/1.32.0-wmf.20+3 -0
StudentPager: Ensure $retValue exists in all code pathsmediawiki/extensions/EducationProgrammaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Sep 5 2018, 3:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2018, 3:09 PM
Aklapper added a comment.Sep 5 2018, 3:41 PM

https://gerrit.wikimedia.org/r/#/q/I430cf0cc04a88249309130e18797b6b6f85c4c95 renamed value to retValue (however the logic didn't change)

thcipriani added a subscriber: Legoktm.Sep 5 2018, 3:54 PM
In T203577#4559866, @Aklapper wrote:

https://gerrit.wikimedia.org/r/#/q/I430cf0cc04a88249309130e18797b6b6f85c4c95 renamed value to retValue (however the logic didn't change)

Adding @Legoktm

gerritbot subscribed.Sep 5 2018, 5:40 PM

Change 458220 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/EducationProgram@master] StudentPager: Ensure $retValue exists in all code paths

https://gerrit.wikimedia.org/r/458220

gerritbot added a project: Patch-For-Review.Sep 5 2018, 5:40 PM
Legoktm claimed this task.Sep 5 2018, 5:41 PM

My bad, I missed a few code paths apparently in the rename.

gerritbot added a comment.Sep 5 2018, 6:16 PM

Change 458220 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] StudentPager: Ensure $retValue exists in all code paths

https://gerrit.wikimedia.org/r/458220

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 7:00 PM
gerritbot added a comment.Sep 5 2018, 7:01 PM

Change 458273 had a related patch set uploaded (by Jforrester; owner: Legoktm):
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.20] StudentPager: Ensure $retValue exists in all code paths

https://gerrit.wikimedia.org/r/458273

Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 5 2018, 10:39 PM
Krinkle moved this task from Older to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Resolved on the Wikimedia-production-error board.
gerritbot added a comment.Sep 5 2018, 11:08 PM

Change 458273 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.20] StudentPager: Ensure $retValue exists in all code paths

https://gerrit.wikimedia.org/r/458273

Stashbot subscribed.Sep 5 2018, 11:14 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-05T23:14:54Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/StudentPager.php: SWAT Fix spammy log errors T203577 (duration: 00m 58s)

Jdforrester-WMF closed this task as Resolved.Sep 5 2018, 11:28 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review.
Jdforrester-WMF subscribed.

Ignore the above.

This is now deployed and has dropped out of fatalmonitor.

Aklapper mentioned this in T203771: Notice: Undefined variable: retValue in /srv/mediawiki/php-1.32.0-wmf.20/extensions/EducationProgram/includes/pagers/OrgPager.php on line 147.Sep 7 2018, 10:04 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL