Page MenuHomePhabricator

Add filters for tags
Open, Needs TriagePublic5 Story Points

Description

Problem: Sometimes one user makes many edits after each other. As somebody who controls the quality of the article, I want to see all changes made at once, and not seperated in edits (which makes it harder to understand the edits as a whole). It is possible to see the revisions authors at a glance in the history view. In the revision slider, this is more complicated

Solution:

  • Next to all tags that appear in the info tool tip, add a bubble (as shown in the mock).
  • When users hover over that bubble, the corresponding row is circled, and all revisions where that tag was added are highlighted. Once the hovering ends, the highlighting ends.
  • When users click on the bubble, the corresponding row is circled, and all revisions where that tag was added are highlighted. The highlighting stays, until the bubble is clicked again, or until another filter was applied name was selected.
  • There is always just one active filter. E.g. if currently all edits by a certain user are highlighted, and then I select the bubble next to the blanked tag, the filter for the specific user is lost, and only edits with the blanked tag are highlighted
  • Highlighted revisions through hovering does not remove a currently active filter. E.g. if currently all edits by a user are highlighted, and then I hover over the blanked tag, I only see the blanked revisions and not the edits of a user. However, when I don't hover over the 'blanked' tag, the filter by user name is again reinstated
  • The filter behavior when something is selected or hovered over always works as described above, no matter if the competing filters are tag or user name filters.

Design details:
circle color changes: normal:#E3E3E3, selected: #CCC, border: 1px black, 30% opacity.
border around the row when selected: #E0E0E0
The corresponding edit-bars in the diagram also change color: 10% darker, border black, 30% opacity.

Mock

Notes
Although the mock shows bubbles both for user names and tags, this ticket is for tags only. The user name filtering is handled in T136105. At the end, users should have the same experience in both cases, though.

Details

Related Gerrit Patches:
mediawiki/extensions/RevisionSlider : masterAdd filters for tags

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptSep 5 2018, 4:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SrishtiSethi moved this task from Sprint Backlog to Doing on the Season of RevisionSlider board.

@Lea_WMDE The bubbles that we are supposed to show for supporting filter;s do they have to be next to both username and tags, is that right? We don't seem to have a filter for viewing edits by username yet, and I'm wondering if this task is about supporting filters for both tags and username.

@SrishtiSethi in the end there will be bubbles both for user names and for tags, but this ticket is only about the tagging part. Thanks for pointing out the unclarity, I will edit the task description to make that more clear :)

Lea_WMDE updated the task description. (Show Details)Sep 21 2018, 1:05 PM

Change 469393 had a related patch set uploaded (by SrishtiSethi; owner: srish):
[mediawiki/extensions/RevisionSlider@master] Add filters for tags

https://gerrit.wikimedia.org/r/469393

Lea_WMDE set the point value for this task to 5.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 20 2019, 11:45 AM

Change 469393 had a related patch set uploaded (by WMDE-Fisch; owner: srish):
[mediawiki/extensions/RevisionSlider@master] Add filters for tags

https://gerrit.wikimedia.org/r/469393

Change 469393 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Add filters for tags

https://gerrit.wikimedia.org/r/469393