Page MenuHomePhabricator
Create Task
Maniphest T203589

SWAT $wgPopupsBetaFeature reading web config cleanup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

$wgPopupsBetaFeature is not referenced anywhere and no longer exists in Popups.

@Prtksxna has kindly written the patches to address this problem but they need SWATing.

Acceptance criteria

  • Rebase patches
  • SWAT the three patches in order.
  • Confirm Popups working per normal.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove obsolete $wgPopupsBetaFeature, Part III: InitialiseSettingsPrtksxnaoperations/mediawiki-configmaster+0 -4
Remove obsolete $wgPopupsBetaFeature, Part I: CommonSettingsPrtksxnaoperations/mediawiki-configmaster+1 -4
Remove obsolete $wgPopupsBetaFeature, Part II: InitialiseSettings-labsJforresteroperations/mediawiki-configmaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 5 2018, 5:46 PM
Herald added a subscriber: Aklapper. · View Herald TranscriptSep 5 2018, 5:46 PM
gerritbot subscribed.Sep 5 2018, 5:46 PM

Change 450906 had a related patch set uploaded (by Jdlrobson; owner: Prtksxna):
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part I: CommonSettings

https://gerrit.wikimedia.org/r/450906

gerritbot added a project: Patch-For-Review.Sep 5 2018, 5:46 PM

Change 444574 had a related patch set uploaded (by Jdlrobson; owner: Prtksxna):
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part III: InitialiseSettings

https://gerrit.wikimedia.org/r/444574

gerritbot added a comment.Sep 5 2018, 5:47 PM

Change 452863 had a related patch set uploaded (by Jdlrobson; owner: Jforrester):
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part II: InitialiseSettings-labs

https://gerrit.wikimedia.org/r/452863

Jdlrobson updated the task description. (Show Details)Sep 5 2018, 5:47 PM
Jdlrobson added a project: Technical-Debt.
Framawiki moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.Sep 5 2018, 7:03 PM
Framawiki subscribed.
Jdlrobson triaged this task as High priority.Sep 11 2018, 4:44 PM
Herald added a subscriber: Dereckson. · View Herald TranscriptSep 11 2018, 4:44 PM
Jdlrobson set the point value for this task to 2.Sep 11 2018, 4:50 PM
Jdlrobson added a comment.Sep 13 2018, 4:24 PM

@Dereckson expressed an interest in deploying this. If you plan to, I'd advise doing it early next week. Let me know if I can help!

Jdlrobson mentioned this in T204609: Turn on page issues A/B test for Latvian Wikipedia, and conduct data checks.Sep 18 2018, 6:00 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q1); removed: Web-Team-Backlog-Archived.Sep 19 2018, 4:49 PM

Swatting at 4pm PST

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 19 2018, 4:49 PM
gerritbot added a comment.Sep 19 2018, 11:12 PM

Change 450906 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part I: CommonSettings

https://gerrit.wikimedia.org/r/450906

gerritbot added a comment.Sep 19 2018, 11:12 PM

Change 452863 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part II: InitialiseSettings-labs

https://gerrit.wikimedia.org/r/452863

gerritbot added a comment.Sep 19 2018, 11:12 PM

Change 444574 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove obsolete $wgPopupsBetaFeature, Part III: InitialiseSettings

https://gerrit.wikimedia.org/r/444574

Stashbot subscribed.Sep 19 2018, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-19T23:21:00Z] <catrope@deploy1001> Synchronized wmf-config/CommonSettings.php: Remove obsolete $wgPopupsBetaFeature, part 1 (T203589) (duration: 00m 56s)

Stashbot added a comment.Sep 19 2018, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-19T23:21:58Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Remove obsolete $wgPopupsBetaFeature, part 2 (T203589) (duration: 00m 56s)

Jdlrobson closed this task as Resolved.Sep 19 2018, 11:35 PM
Jdlrobson claimed this task.
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

This can skip QA and design review as it's removing dead code.

Jdlrobson updated the task description. (Show Details)Sep 19 2018, 11:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits