Page MenuHomePhabricator
Create Task
Maniphest T203600

[BUG] The template link and delete icons should have screenreader-friendly labels
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Problem:

The link and delete icons do not have screenreader usable labels. This should be fixed.

image.png (178×312 px, 8 KB)

Proposed solution:

  • For the link icon, add the label: View template
  • For the delete icon, add the label: Remove template

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/TemplateWizardmaster+14 -1Add 'title' to the icon buttons in TemplateWizard
Customize query in gerrit

Related Objects

Event Timeline

Niharika triaged this task as Medium priority.Sep 5 2018, 7:55 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2018, 7:55 PM
Niharika added a project: MediaWiki-extensions-TemplateWizard.Sep 5 2018, 8:06 PM
Niharika merged a task: T203602: Add title (tooltip) to icon buttons in TemplateWizard for accessibility.Sep 5 2018, 8:10 PM
Niharika added a subscriber: Mooeypoo.
gerritbot added a subscriber: gerritbot.Sep 5 2018, 8:13 PM

Change 458286 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/TemplateWizard@master] Add 'title' to the icon buttons in TemplateWizard

https://gerrit.wikimedia.org/r/458286

gerritbot added a project: Patch-For-Review.Sep 5 2018, 8:13 PM
Mooeypoo claimed this task.Sep 5 2018, 8:16 PM
Mooeypoo set the point value for this task to 0.5.
Mooeypoo added a project: Community-Tech-Sprint.
Mooeypoo moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Niharika moved this task from To Be Estimated/Discussed to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Sep 5 2018, 8:17 PM
gerritbot added a comment.Oct 5 2018, 1:37 AM

Change 458286 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Add 'title' to the icon buttons in TemplateWizard

https://gerrit.wikimedia.org/r/458286

Samwilson moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.Oct 5 2018, 1:41 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 5 2018, 2:00 AM
Samwilson closed this task as Resolved.Nov 6 2018, 7:26 AM
Samwilson moved this task from QA to Q2 2018-19 on the Community-Tech-Sprint board.
Samwilson added a subscriber: Samwilson.

This is working and in production.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL