Page MenuHomePhabricator

Use hot-shots native childClient in service-runner makeChild
Closed, ResolvedPublic


Currently the service-runner metrics.makeChild() creates an entirely new statsd reporter instance. This should be changed to use hot-shots childClient function - it shares the sockets between children, so it's more efficient. Also, it shares the batching queue, so the close method needs to be only called on the parent metrics object - this will allow us to stop storing the list of children for every metrics object.

The only function of the makeChild method is to add a prefix to a metric name which is totally doable with hot-shots native childClient is capable of doing so.