Page MenuHomePhabricator
Create Task
Maniphest T203618

Visual editor emits many init events with platform "other"
Closed, ResolvedPublic
Actions

Description

The visual editor and the 2017 wikitext editor emit many init events with the platform set to other, which shouldn't happen.

According to @DLynch:

The init platform:other issue is that our tracking code tries to work out the platform via platform: ve.init && ve.init.target && ve.init.target.constructor.static.platformType || 'other',

Unfortunately, almost everywhere that we try to log init from hasn't yet loaded the target. Given that most of these are inside ve.init.mw.DesktopArticleTarget.init.js, I think we could safely just hardcode platform: 'desktop' in those calls. (Look for trackActivateStart in that file.)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+14 -1DesktopArticleTarget.init: Pass platform to ve.track directly
Customize query in gerrit

Related Objects
Search...

Event Timeline

nshahquinn-wmf renamed this task from Visual editor many init events with platform "other" to Visual editor emits many init events with platform "other".Sep 5 2018, 11:21 PM
nshahquinn-wmf triaged this task as Medium priority.
nshahquinn-wmf created this task.
nshahquinn-wmf updated the task description. (Show Details)
DLynch added a comment.Sep 5 2018, 11:24 PM

Patch for this already exists: https://gerrit.wikimedia.org/r/455850

DLynch claimed this task.Sep 5 2018, 11:24 PM
nshahquinn-wmf mentioned this in T202437: Identify and fix data quality problems in the Edit event log.Sep 5 2018, 11:26 PM
nshahquinn-wmf moved this task from Triage to Tracking on the Product-Analytics board.Sep 5 2018, 11:38 PM
gerritbot added a subscriber: gerritbot.Sep 6 2018, 3:53 PM

Change 455850 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Pass platform to ve.track directly

https://gerrit.wikimedia.org/r/455850

gerritbot added a project: Patch-For-Review.Sep 6 2018, 3:53 PM
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 6 2018, 3:53 PM
gerritbot added a comment.Sep 12 2018, 2:20 PM

Change 455850 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Pass platform to ve.track directly

https://gerrit.wikimedia.org/r/455850

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 12 2018, 3:00 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 12 2018, 8:09 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 13 2018, 11:34 PM
Ryasmeen added a subscriber: Ryasmeen.Sep 14 2018, 10:32 PM

Anything for me to check here @DLynch?

DLynch added a comment.Sep 17 2018, 2:20 PM

@Ryasmeen Sort of. You could paste this into your browser console:

ve.trackSubscribe( 'mwedit.init', function(topic, data) { console.log('init', (data && data.platform) ? data.platform : 'MISSING'); } );

...and then activate VE and make sure that it says "init desktop" rather than "init MISSING".

Ryasmeen added a comment.Sep 17 2018, 8:37 PM
In T203618#4589042, @DLynch wrote:

@Ryasmeen Sort of. You could paste this into your browser console:

ve.trackSubscribe( 'mwedit.init', function(topic, data) { console.log('init', (data && data.platform) ? data.platform : 'MISSING'); } );

...and then activate VE and make sure that it says "init desktop" rather than "init MISSING".

Cool! Verified that by switching to VE from different tabs as well.

Ryasmeen added a project: Verified.Sep 17 2018, 8:37 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
nshahquinn-wmf closed this task as Resolved.Sep 24 2018, 4:53 PM

This has been fixed!

select
    left(timestamp, 8) as day,
    count(*) as events
from log.Edit_17541122
where
    event_editor = "visualeditor" and
    event_platform = "other" and
    timestamp >= "20180911"
group by left(timestamp, 8)

         day  events
0   20180911   11167
1   20180912   10766
2   20180913   10711
3   20180914    9889
4   20180915    7868
5   20180916    8627
6   20180917   10980
7   20180918   11441
8   20180919   10839
9   20180920    7384
10  20180921       5
11  20180922       1
12  20180923       1
13  20180924       6
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 24 2018, 4:53 PM
nshahquinn-wmf mentioned this in T205309: 2017 wikitext editor emits many ready events with platform "other".Sep 24 2018, 4:58 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL