Page MenuHomePhabricator

Implementations of the Edit schema generate session IDs differently
Closed, DeclinedPublic

Description

Event Timeline

Neil_P._Quinn_WMF triaged this task as Normal priority.Sep 5 2018, 11:33 PM
Neil_P._Quinn_WMF created this task.
DLynch added a comment.Sep 6 2018, 3:36 AM

I think you might be wrong about MobileFrontend using the persistent sessionId. Far as I can tell, it generates a new one via mw.user.generateRandomSessionId() for all the editor event logging every time the editor route is reached. (See: MinervaNeue's definition of the editor options in skins.minerva.editor/init.js.)

WikiEditor's approach seems harmless. It's a unique code per-pageview, like the other two.

Is anything here causing a problem?

(Obviously, there's a future problem if you want the usage stuff we're logging for T202656 to use the same editing session ID as mobile. But that's surmountable, and not yet part of the requirements. 😜)

Neil_P._Quinn_WMF closed this task as Declined.Sep 7 2018, 12:06 AM

I think you might be wrong about MobileFrontend using the persistent sessionId. Far as I can tell, it generates a new one via mw.user.generateRandomSessionId() for all the editor event logging every time the editor route is reached. (See: MinervaNeue's definition of the editor options in skins.minerva.editor/init.js.)

Yeah, you're right. I was confusing the session token they use for their own schemas with the separate one they generate for the Edit schema.

So there's no bug here. I think we will want to revisit how we identify sessions in the future, but now there's not much urgency.