Page MenuHomePhabricator
Create Task
Maniphest T203630

Configure CI to run phan-taint-check-plugin for MediaWiki core
Closed, ResolvedPublic
Actions

Description

@Bawolff I assume the setup process is the same except we use the seccheck-mw script?

Details

ProjectBranchLines +/-Subject
integration/configmaster+1 -1jjb: Use core mode for core-seccheck-docker
integration/configmaster+30 -0Add experimental mediawiki-core-php70-phan-seccheck-docker job
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Sep 6 2018, 5:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 5:34 AM
Bawolff added a comment.Sep 6 2018, 11:34 AM

Yes.

There are still quite a few false positives to sort out, but its starting to get more manageable

gerritbot added a subscriber: gerritbot.Sep 24 2018, 5:47 AM

Change 462341 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add experimental mediawiki-core-php70-phan-seccheck-docker job

https://gerrit.wikimedia.org/r/462341

gerritbot added a project: Patch-For-Review.Sep 24 2018, 5:47 AM
gerritbot added a comment.Sep 24 2018, 6:10 AM

Change 462341 merged by jenkins-bot:
[integration/config@master] Add experimental mediawiki-core-php70-phan-seccheck-docker job

https://gerrit.wikimedia.org/r/462341

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jan 25 2019, 10:59 PM
Bawolff moved this task from Backlog to MediaWiki mode on the phan-taint-check-plugin board.Feb 17 2019, 12:28 PM
sbassett mentioned this in T218091: Security Team quarterly check in for April - June 2019.Apr 19 2019, 7:02 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:40 PM
sbassett changed the status of subtask T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core from Open to Stalled.Jun 26 2019, 7:21 PM
gerritbot added a comment.Jul 12 2019, 11:48 AM

Change 522424 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[integration/config@master] jjb: Use core mode for core-seccheck-docker

https://gerrit.wikimedia.org/r/522424

gerritbot added a project: Patch-For-Review.Jul 12 2019, 11:48 AM
Daimona claimed this task.Jul 12 2019, 11:48 AM
Daimona changed the status of subtask T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core from Stalled to Open.
gerritbot added a comment.Jul 15 2019, 10:47 AM

Change 522424 merged by jenkins-bot:
[integration/config@master] jjb: Use core mode for core-seccheck-docker

https://gerrit.wikimedia.org/r/522424

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 11:11 AM
hashar closed this task as Resolved.Aug 27 2019, 12:41 PM
hashar added a subscriber: hashar.

It seems that has been solved.

Daimona added a comment.Aug 27 2019, 12:46 PM
In T203630#5441293, @hashar wrote:

It seems that has been solved.

Yes, or at least, CI has been configured. We still have to enable seccheck for core, but I'll open another task for that.

Daimona mentioned this in T231311: Enable seccheck for MW core.Aug 27 2019, 12:48 PM
sbassett moved this task from MediaWiki mode to Done on the phan-taint-check-plugin board.Oct 15 2019, 6:55 PM
sbassett triaged this task as Medium priority.Oct 15 2019, 7:25 PM
Umherirrender closed subtask T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core as Resolved.Dec 31 2020, 10:14 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL