Page MenuHomePhabricator

Use NumberInputWidget in HTMLFloatField
Closed, ResolvedPublic

Description

With T194089: Add (infusable) NumberInputWidget in PHP, OOUI now provides a PHP implementation of the number input widget, allowing it to be infused with the correct widget. In HTMLForm however, the TextInputWidget inherited from HTMLTextField is still used. This prevents infusing HTMLFloatFields and HTMLIntFields as a number input widget.

Event Timeline

Change 458492 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Use NumberInputWidget in HTMLFloatField

https://gerrit.wikimedia.org/r/458492

It looks like we have some bugs in how we handle the 'step' config option in OOUI. I think we should wait for the fix for T203766 first.

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Sep 8 2018, 12:40 AM

Change 458492 merged by jenkins-bot:
[mediawiki/core@master] Use NumberInputWidget in HTMLFloatField

https://gerrit.wikimedia.org/r/458492

Mainframe98 triaged this task as Normal priority.Sep 12 2018, 5:07 PM
Mainframe98 closed this task as Resolved.
Mainframe98 claimed this task.