Page MenuHomePhabricator

Make FunFunFactory logic-less
Open, Needs TriagePublic

Description

FunFunFactory should only contain object creation code that does not need to be tested, as it's basically "configuration code". And it's only responsibility should be generating class instances. Currently, FunFunFactory contains some foreach, if and try..catch statements. Those should be moved into unit-tested classes (factories, loaders, etc).

Value Factors: Testability, Velocity, Code Quality, Consistency

Related Objects