Page MenuHomePhabricator

Set PPFrame volatile inside functions accessing the Variables store
Open, MediumPublic

Description

Currently, the Variables store can be accessed without marking the PPFrame as volatile. This should be made impossible by forcing functions to pass a PPFrame when accessing Variables.

We should implement passing a PPFrame as optional by now, but trigger wfWarn if it isn't provided. After the MW 1.32 branching point, it should be changed to a required function argument.

Event Timeline

MGChecker created this task.Sep 6 2018, 2:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 2:45 PM
MGChecker triaged this task as High priority.Sep 19 2018, 12:56 AM
MGChecker lowered the priority of this task from High to Medium.Oct 25 2018, 12:47 AM