Maniphest T203695

Drastically reduce the number of ResourceLoader modules that CX creates
Closed, ResolvedPublic
Actions

Description

As of 7 May 2018 in production, ContentTranslation's own 131 RL modules result in 6573 bytes being shipped on every page view for every reader. That's 3TiB a day of extra load on readers. There's even more if you count the ULS stuff CX uses, but I'll leave that for now.

Ideally CX would only ship itself in two modules – a skinny 'loader' and the full-fat rest of the product – but any reduction would be worthwhile.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/ContentTranslation	master	+5 -23	Merge category widget modules
mediawiki/extensions/ContentTranslation	master	+41 -80	Merge RL modules into mw.cx.MwApiRequestManager and mw.cx.init.Translation
mediawiki/extensions/ContentTranslation	master	+30 -81	Merge all columns related UI modules into mw.cx.ui.TranslationView
mediawiki/extensions/ContentTranslation	master	+12 -25	Merge RL module mw.cx.VersionSwitcher in ext.cx.dashboard
mediawiki/extensions/ContentTranslation	master	+8 -41	Merge RL module ext.cx.contributions.init and ext.cx.contributions
mediawiki/extensions/ContentTranslation	master	+6 -17	Merge RL modules ext.cx.pageselector and ext.cx.tools.link
mediawiki/extensions/ContentTranslation	master	+1 -9	Merge RL modules ext.cx.editor and ext.cx.translation
mediawiki/extensions/ContentTranslation	master	+1 -43	Remove unused RL module mw.cx.ui.mixin and file

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T202154 Audit modules 2018: Reduce registry overhead
Resolved	santhosh	T203695 Drastically reduce the number of ResourceLoader modules that CX creates
Resolved	• Petar.petkovic	T221361 mw.cx.widgets.ProgressBarWidget.js is not used anywhere

Event Timeline

Jdforrester-WMF triaged this task as Medium priority.Sep 6 2018, 5:15 PM

Jdforrester-WMF created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 5:15 PM

Jdforrester-WMF removed Krinkle as the assignee of this task.Sep 6 2018, 5:15 PM

Jdforrester-WMF added a subscriber: Krinkle.

Jdforrester-WMF raised the priority of this task from Medium to Needs Triage.Sep 6 2018, 5:23 PM

Jdforrester-WMF mentioned this in T202154: Audit modules 2018: Reduce registry overhead.Sep 6 2018, 5:34 PM

Pginer-WMF triaged this task as Medium priority.Sep 7 2018, 11:23 AM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

• Petar.petkovic added a subscriber: • Petar.petkovic.Sep 7 2018, 3:17 PM

Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board.Sep 10 2018, 6:01 PM

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Sep 15 2018, 12:33 AM

Volker_E added a subscriber: Volker_E.Oct 11 2018, 8:00 PM

Krinkle moved this task from Watching to Perf issue on the Performance-Team (Radar) board.Jan 21 2019, 12:55 AM

Krinkle moved this task from Perf issue to Perf recommendation on the Performance-Team (Radar) board.Jan 21 2019, 12:57 AM

Krinkle edited projects, added Language-Team; removed Performance Issue.Jan 21 2019, 1:57 AM

Pginer-WMF edited projects, added Language-Team (Language-2019-January-March); removed Language-Team.Jan 21 2019, 7:43 AM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-January-March) board.Jan 21 2019, 1:59 PM

santhosh claimed this task.Jan 22 2019, 12:08 PM

santhosh moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-January-March) board.

Change 485795 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge RL module ext.cx.contributions.init and ext.cx.contributions

https://gerrit.wikimedia.org/r/485795

Change 485796 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge RL module mw.cx.VersionSwitcher in ext.cx.dashboard

https://gerrit.wikimedia.org/r/485796

Change 485797 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge RL modules ext.cx.editor and ext.cx.translation

https://gerrit.wikimedia.org/r/485797

Change 485798 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge RL modules ext.cx.pageselector and ext.cx.tools.link

https://gerrit.wikimedia.org/r/485798

Change 486008 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge RL modules into mw.cx.MwApiRequestManager and mw.cx.init.Translation

https://gerrit.wikimedia.org/r/486008

Change 486009 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Remove unused RL module mw.cx.ui.mixin and file

https://gerrit.wikimedia.org/r/486009

Change 486015 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Merge all columns related UI modules into mw.cx.ui.TranslationView

https://gerrit.wikimedia.org/r/486015

Change 486009 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove unused RL module mw.cx.ui.mixin and file

https://gerrit.wikimedia.org/r/486009

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 23 2019, 8:01 AM

Change 485797 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge RL modules ext.cx.editor and ext.cx.translation

https://gerrit.wikimedia.org/r/485797

Change 485798 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge RL modules ext.cx.pageselector and ext.cx.tools.link

https://gerrit.wikimedia.org/r/485798

Change 485795 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge RL module ext.cx.contributions.init and ext.cx.contributions

https://gerrit.wikimedia.org/r/485795

Change 485796 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge RL module mw.cx.VersionSwitcher in ext.cx.dashboard

https://gerrit.wikimedia.org/r/485796

Change 486015 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge all columns related UI modules into mw.cx.ui.TranslationView

https://gerrit.wikimedia.org/r/486015

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.19; 2019-02-26); removed MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 20 2019, 2:00 PM

Change 486008 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Merge RL modules into mw.cx.MwApiRequestManager and mw.cx.init.Translation

https://gerrit.wikimedia.org/r/486008

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Mar 17 2019, 5:02 AM

• Petar.petkovic removed a project: Patch-For-Review.Mar 18 2019, 12:26 AM

On 1st April 2019, we have 111 RL modules in CX

Some canidate modules to remove:

mw.cx.dm.TranslationIssue - used only by mw.cx.init.Translation and lazy loaded in it. It does not look a candidate for lazy loading now. If we can merge it with mw.cx.init.translation, that should reduce on RL module. It has only a single script file
mw.cx.ui.Columns.legacy and mw.cx.ui.SourceColumn.legazy etc- all for cx1. cx1 is going to be there for another year. So clubbing all of them to a single module is a good idea. Just like we did for cx2
mw.cx.ui.CategoryTagItemWidget, mw.cx.ui.CategoryInputWidget and mw.cx.ui.CategoryMultiselectWidget can be merged

In T203695#5075946, @santhosh wrote:

mw.cx.dm.TranslationIssue - used only by mw.cx.init.Translation and lazy loaded in it. It does not look a candidate for lazy loading now. If we can merge it with mw.cx.init.Translation, that should reduce on RL module. It has only a single script file

mw.cx.dm.TranslationIssue is also lazy loaded in ve.dm.CXLintableNode. Also, mw.cx.init.Translation.prototype.checkForTranslationChanges is always called, but the early return is hit more times than not, so we should not merge this module.

In T203695#5075946, @santhosh wrote:

mw.cx.ui.CategoryTagItemWidget, mw.cx.ui.CategoryInputWidget and mw.cx.ui.CategoryMultiselectWidget can be merged

This can definitely be done. I'll submit a patch.

Change 500625 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Merge category widget modules

https://gerrit.wikimedia.org/r/500625

gerritbot added a project: Patch-For-Review.Apr 1 2019, 10:13 PM

Pginer-WMF edited projects, added Language-Team (Language-2019-April-June); removed Language-Team (Language-2019-January-March).Apr 2 2019, 11:25 AM

Pginer-WMF moved this task from Backlog to In Progress on the Language-Team (Language-2019-April-June) board.

Change 500625 merged by KartikMistry:
[mediawiki/extensions/ContentTranslation@master] Merge category widget modules

https://gerrit.wikimedia.org/r/500625

• Petar.petkovic removed a project: Patch-For-Review.Apr 2 2019, 7:23 PM

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Apr 2 2019, 8:01 PM

Krinkle added a subtask: T221361: mw.cx.widgets.ProgressBarWidget.js is not used anywhere.Apr 18 2019, 11:24 PM

As of today we have 106 RL modules. So as part of this ticket we reduced 25 RL modules. I am moving this ticket to done, but we need to actively look for more opportunities to reduce RL modules as we refactor or enhance featues.

CX1 co-existing with CX2 is the main reason behind many modules. CX1 code will be removed by end of this year and expecting about 50& reduction about RL modules.