Page MenuHomePhabricator
Create Task
Maniphest T203720

Dropdown menus are misaligned too far away from buttons on mediawiki.org
Closed, InvalidPublic
Actions

Description

Steps to reproduce:

  1. Go to any article on mediawiki.org
  2. Open the visual editor
  3. Click "Insert", or any of the other buttons that open dropdowns

Expected behaviour:

  • The top of the dropdown is aligned with the bottom of the button

Actual behaviour:

  • The top of the dropdown is too low, making the menu float somewhat

Related Objects

Event Timeline

Deskana created this task.Sep 6 2018, 10:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 10:21 PM
Deskana triaged this task as High priority.Sep 6 2018, 10:21 PM

Not impacting production yet...

matmarex added a subscriber: matmarex.Sep 6 2018, 10:42 PM

I can't reproduce.

Deskana renamed this task from Dropdown menus are misaligned too far away from buttons on mediawiki.org and the beta cluster to Dropdown menus are misaligned too far away from buttons on mediawiki.org.Sep 7 2018, 2:56 AM
Deskana updated the task description. (Show Details)
Deskana added a comment.Sep 7 2018, 2:59 AM

I can't reproduce this on the beta cluster any more (or perhaps I never could and simply got my tabs confused?) but I can still reproduce on mediawiki.org.

Schnark added a subscriber: Schnark.Sep 7 2018, 9:06 AM

If you're using a zoom level > 100%, then this is a duplicate of T199752: Toolbar menu positioning broken when zoom level > 100% (and if you aren't, it might be related anyway).

Deskana added a subscriber: Ryasmeen.EditedSep 7 2018, 3:54 PM
In T203720#4565529, @Schnark wrote:

If you're using a zoom level > 100%, then this is a duplicate of T199752: Toolbar menu positioning broken when zoom level > 100% (and if you aren't, it might be related anyway).

I'm at 100% zoom, so it's not the same issue, but as you say they could be related.

@Ryasmeen Your help diagnosing this would be very much appreciated.

matmarex mentioned this in T199752: Toolbar menu positioning broken when zoom level > 100%.Sep 7 2018, 4:34 PM
matmarex added a comment.Sep 7 2018, 4:37 PM

I can reproduce @Schnark's issue (with 110% zoom), but not with 100% zoom. So I tried to debug that one, and I'm happy to report that it was caused by a jQuery bug (https://github.com/jquery/jquery/issues/3808) and has been just fixed by rMWdbbb45eadb18: Update jQuery from v3.2.1 to v3.3.1. The fix is live on the Beta Cluster, but not on production wikis.

@Deskana If you can reproduce on mediawiki.org but not on the Beta Cluster, then maybe this is the same issue? I guess maybe it could be caused by some operating system DPI settings or something?

Deskana changed the task status from Open to Stalled.Sep 13 2018, 10:58 PM

This issue is still present for me, but I can't reproduce the issue in Safari or in an incognito window. I think the onus is on me to try to diagnose exactly what it is about my setup that is causing this issue...

Ryasmeen added a comment.Sep 13 2018, 11:01 PM

I tried to reproduce this too on different browsers, not happening for me.

JTannerWMF moved this task from Incoming to Stalled/Waiting on the VisualEditor (Current work) board.Sep 19 2018, 4:32 PM
JTannerWMF added a subscriber: JTannerWMF.

Hey @Deskana we are going to move this to stalled for you to further explore it and determine if you would like to close it out.

Deskana closed this task as Invalid.Sep 27 2018, 3:07 PM

I can't reproduce this any more, and given that nobody else could reproduce this issue either, I assume it was something silly on my end.

Ryasmeen mentioned this in T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up.Oct 4 2018, 5:13 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL