Page MenuHomePhabricator

Icon correct but issuesSeverity in instrumentation is wrong
Closed, ResolvedPublic

Description

Visit https://reading-web-staging.wmflabs.org/w/index.php?title=Stone_Cold_Steve_Austin in the new page issues treatment.
After the fix for T203386: Multiple-issues templates in page sections don't render in modal, the multiple issues template in Section 2 is displayed correctly now. However:

sectionNumbers is logged as [2]
issuesSeverity is logged as ["LOW"]
However when I click the issue box, I notice there is a medium issue.

Expected: issuesSeverity should be ["MEDIUM"]

Details

Related Gerrit Patches:
mediawiki/skins/MinervaNeue : masterFix `formatPageIssuesSeverity`

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 11:41 PM
Tbayer updated the task description. (Show Details)Sep 6 2018, 11:47 PM

Change 458622 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] WIP: Test case for T203725

https://gerrit.wikimedia.org/r/458622

Change 458622 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix formatPageIssuesSeverity

https://gerrit.wikimedia.org/r/458622

This is working now but will confirm with Tilman.

Tbayer closed this task as Resolved.Sep 10 2018, 7:52 PM

We checked and it's working correctly in this test case now.