Maniphest T203738

Add tooltips
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Add tooltips to the following buttons/icons:

Tooltips on hover

Help icon: Show help
Selected radio button: Selected version
Unselected radio button: Click to select this version
Edit icon of a selected text box (black pencil): Click to edit this text
Check mark: Apply your changes to this text
Back arrow: Discard all your changes to this text
Arrow down: Expand unchanged text
Arrow up: Collapse unchanged text

Notes

We will need to set the title option of the OOUI button widgets
We will need to remember that those texts should be localized

Details

	Subject	Repo	Branch	Lines +/-
	Use native tooltip for two-state edit button	mediawiki/extensions/TwoColConflict	master	+7 -68
	Add more tooltips	mediawiki/extensions/TwoColConflict	master	+26 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T203738 Add tooltips
		Resolved		Andrew-WMDE	T195722 Tooltip for unselected paragraphs (No. 7)

Event Timeline

JStrodt_WMDE created this task.Sep 7 2018, 5:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2018, 5:59 AM

Which project is this about? Tag welcome :)

JStrodt_WMDE added a project: Two-Column-Edit-Conflict-Merge.Sep 7 2018, 10:34 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 7 2018, 10:34 AM

In T203738#4565748, @Aklapper wrote:

Which project is this about? Tag welcome :)

Excellent point! :) Thanks.

Thanks @JStrodt_WMDE! Is it a deliberate decision to have all tooltips start with a small letter? And could you maybe merge the other tooltip tickets we have in as well? Otherwise this ticket is for 90% of the cases, and then we have one or two random other ones :)

Lea_WMDE updated the task description. (Show Details)Sep 13 2018, 7:45 AM

Lea_WMDE added a subtask: T195722: Tooltip for unselected paragraphs (No. 7).

Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.

In T203738#4577135, @Lea_WMDE wrote:

Thanks @JStrodt_WMDE! Is it a deliberate decision to have all tooltips start with a small letter?

My reasoning is that complete sentences should start with a capital letter. Example: T195722
All others are merely little hints and no sentences, so they don't need to start with a capital letter or end with a full stop, IMO.

In T203738#4577135, @Lea_WMDE wrote:

And could you maybe merge the other tooltip tickets we have in as well? Otherwise this ticket is for 90% of the cases, and then we have one or two random other ones :)

I only know of T195722, which is linked in the task description. Should I mark this as duplicate?
Do you know of others?

Lea_WMDE updated the task description. (Show Details)Sep 13 2018, 3:11 PM

Lea_WMDE updated the task description. (Show Details)Sep 13 2018, 3:15 PM

Lea_WMDE set the point value for this task to 5.

Lea_WMDE closed subtask T195722: Tooltip for unselected paragraphs (No. 7) as Resolved.Nov 22 2018, 11:40 AM

thiemowmde moved this task from Tickets ready for pickup to Before full default on the Two-Column-Edit-Conflict-Merge board.Dec 4 2019, 9:51 AM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2019-12-11.Dec 11 2019, 12:28 PM

WMDE-Fisch changed the point value for this task from 5 to 3.

WMDE-Fisch removed a project: WMDE-QWERTY-Sprint-2019-12-11.Dec 11 2019, 12:54 PM

WMDE-Fisch moved this task from Before full default to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Jan 8 2020, 2:25 PM

WMDE-Fisch moved this task from Tickets ready for pickup to Before full default on the Two-Column-Edit-Conflict-Merge board.

Andrew-WMDE claimed this task.Jan 24 2020, 1:32 PM

Andrew-WMDE added a project: WMDE-QWERTY-Sprint-2020-01-21.

Change 567078 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Add more tooltips

https://gerrit.wikimedia.org/r/567078

gerritbot added a project: Patch-For-Review.Jan 24 2020, 3:17 PM

Andrew-WMDE moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-01-21 board.Jan 24 2020, 4:00 PM

Change 567078 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Add more tooltips

https://gerrit.wikimedia.org/r/567078

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2020, 5:10 PM

Can be tested on beta https://en.wikipedia.beta.wmflabs.org/wiki/Special:SimulateTwoColEditConflict ( e.g. use Main Page )

thiemowmde moved this task from Before full default to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Jan 28 2020, 12:13 PM

Acceptance review notes:

All tooltips should have a consistent style, so let's (consider, @Hanna_Petruschat_WMDE ) shortening the text of the long, OOUI tooltip.
Currently, the disabled pencil shows two tooltips, both the fancy and the native browser popup.
All the listed tooltips are present, awesome!

Lena_WMDE moved this task from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-01-21 board.Feb 4 2020, 10:55 AM

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-02-04.Feb 4 2020, 1:50 PM

thiemowmde removed Andrew-WMDE as the assignee of this task.Feb 4 2020, 1:57 PM

thiemowmde added a subscriber: Andrew-WMDE.

Lena_WMDE subscribed.Feb 5 2020, 8:55 AM

awight claimed this task.Feb 5 2020, 2:22 PM

awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-02-04 board.

Change 570357 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Use native tooltip for two-state edit button

https://gerrit.wikimedia.org/r/570357

gerritbot added a project: Patch-For-Review.Feb 5 2020, 3:20 PM