Page MenuHomePhabricator
Create Task
Maniphest T203759

Recent Changes shows Internal Error on de.wikipedia.beta.wmflabs.org
Closed, ResolvedPublic
Actions

Description

https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Letzte_%C3%84nderungen currently only shows an "Internal Error". It happens both logged in and logged out, and also on the watchlist, but not on en.wikipedia.beta.wmflabs.org.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/OAuthmaster+4 -0Return when there is no tag to add
mediawiki/extensions/OAuthmaster+1 -1Avoid exceptions in NameTableStore by casting ct_tag_id to int
mediawiki/extensions/OAuthmaster+13 -4Read from ct_tag_id when needed
Customize query in gerrit

Event Timeline

Schnark created this task.Sep 7 2018, 8:56 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 7 2018, 8:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson added a subscriber: SBisson.Sep 7 2018, 11:03 AM

https://github.com/wikimedia/mediawiki-extensions-OAuth/blob/master/backend/MWOAuth.hooks.php#L132

[W5JaDwpEEj4AABgRV7EAAAAD] /wiki/Spezial:Letzte_%C3%84nderungen InvalidArgumentException from line 2113 of /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php: Wikimedia\Rdbms\Database::makeList: empty input for field ct_tag_id

Backtrace:

#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1706): Wikimedia\Rdbms\Database->makeList(array, integer)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1653): Wikimedia\Rdbms\Database->selectSQLText(string, array, array, string, array, array)
#2 /srv/mediawiki/php-master/extensions/OAuth/backend/MWOAuth.hooks.php(144): Wikimedia\Rdbms\Database->select(string, array, array, string, array)
#3 /srv/mediawiki/php-master/extensions/OAuth/backend/MWOAuth.hooks.php(73): MediaWiki\Extensions\OAuth\MWOAuthHooks::getUsedConsumerTags(boolean, array)
#4 /srv/mediawiki/php-master/includes/Hooks.php(174): MediaWiki\Extensions\OAuth\MWOAuthHooks::onListDefinedTags(array)
#5 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#6 /srv/mediawiki/php-master/includes/changetags/ChangeTags.php(1513): Hooks::run(string, array)
#7 /srv/mediawiki/php-master/includes/libs/objectcache/WANObjectCache.php(1277): Closure$ChangeTags::listSoftwareDefinedTags(boolean, integer, array, NULL)
#8 /srv/mediawiki/php-master/includes/libs/objectcache/WANObjectCache.php(1150): WANObjectCache->doGetWithSetCallback(string, integer, Closure$ChangeTags::listSoftwareDefinedTags;1147, array)
#9 /srv/mediawiki/php-master/includes/changetags/ChangeTags.php(1521): WANObjectCache->getWithSetCallback(string, integer, Closure$ChangeTags::listSoftwareDefinedTags;1147, array)
#10 /srv/mediawiki/php-master/includes/changetags/ChangeTags.php(1453): ChangeTags::listSoftwareDefinedTags()
#11 /srv/mediawiki/php-master/includes/changetags/ChangeTags.php(871): ChangeTags::listDefinedTags()
#12 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(662): ChangeTags::buildTagFilterSelector(string, boolean, RequestContext)
#13 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(490): SpecialRecentChanges->getExtraOptions(FormOptions)
#14 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(1597): SpecialRecentChanges->doHeader(FormOptions, integer)
#15 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(1608): ChangesListSpecialPage->webOutputHeader(integer, FormOptions)
#16 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(675): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#17 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(167): ChangesListSpecialPage->execute(NULL)
#18 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(569): SpecialRecentChanges->execute(NULL)
#19 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#20 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#21 /srv/mediawiki/php-master/includes/MediaWiki.php(868): MediaWiki->performRequest()
#22 /srv/mediawiki/php-master/includes/MediaWiki.php(525): MediaWiki->main()
#23 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#24 /srv/mediawiki/w/index.php(3): include(string)
#25 {main}
SBisson added a subscriber: Ladsgroup.Sep 7 2018, 11:05 AM

@Ladsgroup Can this be a consequence of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OAuth/+/452063/ ?

Ladsgroup added a comment.Sep 7 2018, 11:06 AM

Probably. Will check in a sec

Ladsgroup added a comment.Sep 7 2018, 11:10 AM

Yup, It's official. I'm stupid :D how could I miss such thing. Fix it in a second.

gerritbot added a subscriber: gerritbot.Sep 7 2018, 11:16 AM

Change 458779 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/OAuth@master] Read from ct_tag_id when needed

https://gerrit.wikimedia.org/r/458779

gerritbot added a project: Patch-For-Review.Sep 7 2018, 11:16 AM
SBisson assigned this task to Ladsgroup.Sep 7 2018, 1:19 PM
SBisson moved this task from Inbox to External on the Growth-Team board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 7 2018, 1:19 PM
gerritbot added a comment.Sep 7 2018, 2:55 PM

Change 458779 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Read from ct_tag_id when needed

https://gerrit.wikimedia.org/r/458779

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 7 2018, 3:00 PM
Ladsgroup added a comment.Sep 7 2018, 3:40 PM

The patch is merged but it has not deployed in beta cluster yet. It should be though :/ will double check in the next couple of hours.

gerritbot added a comment.Sep 8 2018, 4:11 AM

Change 459016 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/OAuth@master] Avoid exceptions in NameTableStore by casting ct_tag_id to int

https://gerrit.wikimedia.org/r/459016

gerritbot added a comment.Sep 10 2018, 7:59 AM

Change 459016 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Avoid exceptions in NameTableStore by casting ct_tag_id to int

https://gerrit.wikimedia.org/r/459016

gerritbot added a comment.Sep 11 2018, 9:41 AM

Change 459755 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/OAuth@master] Return when there is no tag to add

https://gerrit.wikimedia.org/r/459755

gerritbot added a comment.Sep 12 2018, 4:49 PM

Change 459755 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Return when there is no tag to add

https://gerrit.wikimedia.org/r/459755

Ladsgroup closed this task as Resolved.Sep 14 2018, 11:55 AM

It's fixed now.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL