Page MenuHomePhabricator

API sandbox flags errors too early sometimes
Open, LowPublic

Description

Steps to reproduce:

  1. Open the API sandbox, select "query" as action, make the request.
  2. Return to the main input and change the action to "edit".

Actual result:
The page for edit is flagged as having errors in the index, on that page the edit token is flagged as well.

Expected result:
While it is true that the edit token is mandatory, it shouldn't be flagged yet. Just like it isn't flagged when you omit step 1.

Event Timeline

Schnark created this task.Sep 7 2018, 9:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2018, 9:00 AM
Anomie renamed this task from API sandbox flags errors to early sometimes to API sandbox flags errors too early sometimes.Sep 7 2018, 1:12 PM
Anomie added a subscriber: Anomie.

There's an internal flag for whether errors should be flagged or not, which gets changed to true when you use the "Make request" button and gets changed back to "false" when you use the "Clear" button. It's not clear to me when would be a good time to change it back to false other than when you specifically reset the form with "Clear".

Anomie triaged this task as Low priority.Sep 7 2018, 1:15 PM