It seems the mediawiki codebase is using the not operator ! without a space after it.
I suggest to add a sniff for this case
phpcs does not provide a default sniff for this. It have a sniff to enforce the space after ! - SpaceAfterNotSniff
The sniff should remove a space/tab or newline after not operator. Maybe validate one space before the ! (T_BOOLEAN_NOT) as well (when there is not another !).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Enable Generic.Formatting.SpaceAfterNot with spacing 0 | mediawiki/tools/codesniffer | master | +6 -1 |
Generic.Formatting.SpaceAfterNot takes a property spacing since phpcs3.4.0, needs check if it could be used here
Change 481530 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Enable Generic.Formatting.SpaceAfterNot with spacing 0
I run phpcs to detect the different cases:
| Spacing=1 | Spacing=0 | Extension |
| 1 | 265 | AbuseFilter |
| 1 | 34 | Cite |
| 1 | 250 | Echo |
| 1 | 6 | GPGMail |
| 1 | 57 | LdapAuthentication |
| 1 | 17 | OAuthAuthentication |
| 1 | 26 | PropertySuggester |
| 1 | 57 | ReadingLists |
| 1 | 2 | SimpleSAMLphp |
| 1 | 168 | TimedMediaHandler |
| 1 | 6 | TrustedXFF |
| 1 | 85 | WikimediaMaintenance |
| 2 | 79 | PageTriage |
| 2 | 269 | SecurePoll |
| 2 | 57 | ZeroBanner |
| 3 | 63 | PagedTiffHandler |
| 3 | 30 | ReplaceText |
| 3 | 3 | SafeDelete |
| 3 | 7 | UploadLocal |
| 4 | 0 | Carp |
| 5 | 36 | CommonsMetadata |
| 6 | 7 | Memento |
| 8 | 435 | CirrusSearch |
| 12 | 48 | Math |
| 12 | 13 | SemanticDrilldown |
| 28 | 4 | Arrays |
| 34 | 216 | LiquidThreads |
| 42 | 410 | WikiLexicalData |
All other extensions does not have spacing=1
Uh, awesome. It looks like the MediaWiki-extensions-Arrays might be the only codebase that intentionally uses spaces after ! operators. All others – even if some of the numbers are high – look like mistakes or situations where different developers used inconsistent formatting.
I wrote a comment at https://gerrit.wikimedia.org/r/481530 questioning if adding this rule would make some developers angry. I feel the table above gives an answer: No. It's fine, especially since it's auto-fixable.
Change 481530 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Enable Generic.Formatting.SpaceAfterNot with spacing 0