"add" to what / where?

Presumably the login form itself.

It's the ops group btw: https://phabricator.wikimedia.org/source/operations-puppet/browse/production/modules/netbox/templates/ldap_config.py.erb$39

login form itself and also should be on https://wikitech.wikimedia.org/wiki/LDAP/Groups#Specific_groups

In T203840#4567938, @Dzahn wrote:

also should be on https://wikitech.wikimedia.org/wiki/LDAP/Groups#Specific_groups

well that bit's easy, done

That would require code changes in Netbox and doesn't seem to warrant the overhead. Alex documented the access https://wikitech.wikimedia.org/wiki/LDAP/Groups#Specific_groups and I I think that's good enough.

In T203840#4571522, @MoritzMuehlenhoff wrote:

That would require code changes in Netbox and doesn't seem to warrant the overhead.

Fair enough, i said that assuming it was a puppet change because other services have those strings in the repo. Fine with me closing it then. @Framawiki ok ?

Thanks all !