Page MenuHomePhabricator
Create Task
Maniphest T203864

Resetting a global preference via API does not work
Closed, DuplicatePublic
Actions

Description

Steps to reproduce:

  1. On https://en.wikipedia.org/wiki/Special:GlobalPreferences#mw-prefsection-rendering, set your skin globally to "Modern".
  2. On https://en.wikipedia.org/wiki/Special:ApiSandbox, select globalpreferences as action, select the first example ("Make a single preference non-global", which will make skin non-global again), and make the request.

Expected: The skin should use the local preference again.
Actual: The skin is still global, you have to reset it on Special:GlobalPreferences instead of using the API.

This also happens for other preferences, if you try this with userjs-* preferences there is no way to make them non-global again, as these are not on Special:GlobalPreferences.

Related Objects

Event Timeline

Schnark created this task.Sep 8 2018, 9:23 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 8 2018, 9:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Sep 10 2018, 1:47 PM
Niharika added subscribers: MaxSem, Niharika.Sep 10 2018, 6:26 PM

@MaxSem Can you try and reproduce this bug?

MaxSem added a comment.Sep 10 2018, 6:28 PM

This is blocked on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/445759/ I'll make another pass at it.

Schnark added a comment.Sep 11 2018, 9:26 AM

This also happens for other preferences, if you try this with userjs-* preferences there is no way to make them non-global again, as these are not on Special:GlobalPreferences.

Ignore that. It does work for userjs-* preferences. Probably I just got confused by T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.

Schnark added a comment.Sep 18 2018, 7:01 AM
In T203864#4573455, @Schnark wrote:

This also happens for other preferences, if you try this with userjs-* preferences there is no way to make them non-global again, as these are not on Special:GlobalPreferences.

Ignore that. It does work for userjs-* preferences. Probably I just got confused by T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.

I don't know, what I did when I wrote the last comment, but now it does not work. Steps to reproduce:

  1. Save userjs-foo=foo as global preference: https://de.wikipedia.org/wiki/Spezial:ApiSandbox#action=globalpreferences&format=json&change=userjs-foo%3Dfoo
  2. Confirm it is set properly: https://de.wikipedia.org/wiki/Spezial:ApiSandbox#action=query&format=json&meta=globalpreferences
  3. Remove userjs-foo as global preference: https://de.wikipedia.org/wiki/Spezial:ApiSandbox#action=globalpreferences&format=json&change=userjs-foo
  4. Repeat step 2.

Expected: The preference should be gone.
Actual: It is still there, with the old value, even though step 3 complete with "success".

Pginer-WMF mentioned this in T205493: [testwiki-wmf.23] Cannot disable new version for translations.Sep 28 2018, 10:21 AM
Niharika moved this task from New & TBD Tickets to Engineering Backlog on the Community-Tech board.Oct 1 2018, 9:20 PM
MaxSem closed this task as a duplicate of T65080: Allow users to reset skin preferences to default with api action=options.Oct 2 2018, 2:08 AM
Schnark mentioned this in T207448: Resetting a custom global preference via API does not work.Oct 19 2018, 8:53 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL