Page MenuHomePhabricator

Descriptions recognized only if they use a <div>
Open, Needs TriagePublic

Description

This file uses <table class="description en"> to mark the language of the descriptions, but CommonsMetadata doesn’t recognize that, resulting in the whole description treated as one. (Which is rather annoying, because these descriptions are quite long on their own.) It seems intentional, but the commit Git Blame found doesn’t help a lot.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It uses div because that's what the language templates generate. (See also here.) Tables would be discarded anyway, as CommonsMetadata is not supposed to output complex HTML.

Table syntax is discarded, but not the content of the table, which is a good solution I think. (You can check by opening Media Viewer for the above-mentioned image.) What’s the drawback of enabling any other HTML tag with .description.en class? This template could use an outer <div> to meet CommonsMetadata’s expectations, but I don’t like using more HTML tags than necessary.