Page MenuHomePhabricator

Wrong translation for country names in "I live in $3" in EUCopyrightCampaign extension due to reusing nominative case
Open, Needs TriagePublic

Description

(In the message eucc-email-user-info.)

That results in completely amateurishly sounding text in agglutinative languages. There should be separate country names for that specific message. Even in non-agglutinative languages, the preposition to be used might be different for different countries.

(E.g. in Hungarian, Hungary and Austria are "Magyarország" and "Ausztria" but for "I live in XXX" you'd say "Magyarországon" and "Ausztriában".)

There's a similar issue with eucc-contact-button-tweet-label ("Tweet $1").

Event Timeline

Tgr created this task.Sep 10 2018, 1:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2018, 1:41 AM
Aklapper renamed this task from Country name should not be reused for "I live in $3" in EUCopyrightCampaign extension to Wrong translation for country names in "I live in $3" in EUCopyrightCampaign extension due to reusing nominative case.Sep 10 2018, 9:36 AM

Same issue: Czech version currently says "bydlím v Česko". Must be "bydlím v Česku" instead.

@Tgr for the time being. Hardcode the translation for Hungary. I know its not ideal but it will suffice for now.

Tgr updated the task description. (Show Details)Sep 11 2018, 5:51 AM

I translated it to something like "I am a citizen of $1" which sounds slightly awkward but grammatically correct.

Can {{GRAMMAR}} work here?

Tgr added a comment.Sep 11 2018, 12:39 PM

Can {{GRAMMAR}} work here?

Depends on the language. Hungarian does not support suffixes via {{GRAMMAR}} (I have a very old patch which needs further work) but even if it did, in Hungarian different suffixes are used for different countries (it's "in the EU" but "on Hungary"), I doubt GRAMMAR can help with that. Stuff like {{#if}}, maybe, but I'm not sure if that's safe to use in an i18n message (especially one that might get loaded via Javascript).