Page MenuHomePhabricator

[BUG] After user logged in, the Reading list sync dialog should show CTA as RHS aligned
Closed, ResolvedPublic

Description

Screen Shot 2018-09-10 at 17.53.07.png (271×307 px, 43 KB)

Event Timeline

Looks like this patch: https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/+/431761/ update the alignment of button text to be center.
@Dbrant Should we revert it?

@cooltey @Charlotte Nope, this is the correct standard behavior of buttons in an AlertDialog. The thing that is not good is having button text that overflows onto multiple lines. If we align the button text itself to end instead of center, the buttons will look weird in other ways.

@RHo - see @Dbrant's comment above. What would you like to be done here?

@cooltey @Charlotte Nope, this is the correct standard behavior of buttons in an AlertDialog. The thing that is not good is having button text that overflows onto multiple lines. If we align the button text itself to end instead of center, the buttons will look weird in other ways.

hi @Dbrant @Charlotte - The expected behavior when it is a dialog with stacked full-with buttons dialog is to have them be right-aligned and this is reflected in the Material spec: https://material.io/design/components/dialogs.html#anatomy.
I think this particular instance, having the one button revert to being centre-aligned when it flows over multiple lines is unexpected and weird so would strongly advise fixing.

Change 465790 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: make the reading list sync dialog button text align to the right

https://gerrit.wikimedia.org/r/465790

Change 465790 abandoned by Cooltey:
Fix: make the reading list sync dialog button text align to the right

https://gerrit.wikimedia.org/r/465790