Page MenuHomePhabricator
Create Task
Maniphest T203973

[BUG] "My Lists" view scrollable even when there are not enough lists in there to scroll
Closed, ResolvedPublic
Actions

Description

Screen Shot 2018-09-10 at 17.57.24.png (230×300 px, 40 KB)

  • "My Lists" view scrollable even when there are not enough lists in there to scroll
  • Lists should not be scrollable under the Login prompt panel

Details

SubjectRepoBranchLines +/-
Fix: "My Lists" view scrollable even when there are not enough lists in there to scrollapps/android/wikipediamaster+17 -13
Customize query in gerrit

Event Timeline

• Charlotte created this task.Sep 10 2018, 4:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2018, 4:58 PM
cooltey subscribed.Sep 10 2018, 5:38 PM

Note: this might be the issue from the extra code logic I've made for the floating queue element.

If the floating queue element appears, the list will be added an empty item to it to make the last item visible.

RHo updated the task description. (Show Details)Sep 17 2018, 2:21 PM
cooltey claimed this task.Sep 24 2018, 5:50 PM
cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
gerritbot subscribed.Oct 9 2018, 10:43 PM

Change 465529 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: "My Lists" view scrollable even when there are not enough lists in there to scroll

https://gerrit.wikimedia.org/r/465529

gerritbot added a project: Patch-For-Review.Oct 9 2018, 10:43 PM
cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 9 2018, 10:43 PM
gerritbot added a comment.Oct 10 2018, 1:56 PM

Change 465529 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: "My Lists" view scrollable even when there are not enough lists in there to scroll

https://gerrit.wikimedia.org/r/465529

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 11 2018, 4:06 PM
ABorbaWMF moved this task from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 16 2018, 9:28 PM
ABorbaWMF subscribed.

Looks ok to me on 2.7.239-alpha-2018-10-15

Dbrant closed this task as Resolved.Nov 1 2018, 5:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL