Page MenuHomePhabricator
Create Task
Maniphest T203974

Merge prototype A to main branch
Closed, ResolvedPublic
Actions

Description

Merging the codes in prototype_floating_queue branch on Gerrit to the master branch.

  • The Kotlin related patch may not be considered to be merged into master branch.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Merge prototype A to main branch: Scrollable controller ToCCoolteyapps/android/wikipediamaster+597 -211
Merge prototype A to main branch: Main nav drawerCoolteyapps/android/wikipediamaster+575 -264
Merge prototype A to main branch: Article view and tabsCoolteyapps/android/wikipediamaster+550 -178
Merge prototype A to main branch: Visual design updateCoolteyapps/android/wikipediamaster+312 -137
Merge prototype A to main branch: Floating QueueCoolteyapps/android/wikipediamaster+716 -301
Customize query in gerrit

Event Timeline

LGoto created this task.Sep 10 2018, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2018, 5:00 PM
cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Sep 10 2018, 5:27 PM
cooltey updated the task description. (Show Details)Sep 10 2018, 5:32 PM
gerritbot subscribed.Sep 11 2018, 12:07 AM

Change 459658 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Merge prototype A to main branch: Floating Queue

https://gerrit.wikimedia.org/r/459658

gerritbot added a project: Patch-For-Review.Sep 11 2018, 12:07 AM
gerritbot added a comment.Sep 12 2018, 12:38 AM

Change 459880 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Merge prototype A to main branch: Visual design update

https://gerrit.wikimedia.org/r/459880

gerritbot added a comment.Sep 13 2018, 12:58 AM

Change 460180 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Merge prototype A to main branch: Article view and tabs

https://gerrit.wikimedia.org/r/460180

gerritbot added a comment.Sep 13 2018, 10:24 PM

Change 460448 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Merge prototype A to main branch: Main nav drawer

https://gerrit.wikimedia.org/r/460448

gerritbot added a comment.Sep 13 2018, 11:45 PM

Change 460456 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Merge prototype A to main branch: Scrollable controller ToC

https://gerrit.wikimedia.org/r/460456

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Sep 14 2018, 9:48 PM
gerritbot added a comment.Sep 17 2018, 8:57 PM

Change 459658 merged by jenkins-bot:
[apps/android/wikipedia@master] Merge prototype A to main branch: Floating Queue

https://gerrit.wikimedia.org/r/459658

gerritbot added a comment.Sep 26 2018, 4:07 PM

Change 459880 merged by jenkins-bot:
[apps/android/wikipedia@master] Merge prototype A to main branch: Visual design update

https://gerrit.wikimedia.org/r/459880

gerritbot added a comment.Sep 26 2018, 4:42 PM

Change 460180 merged by jenkins-bot:
[apps/android/wikipedia@master] Merge prototype A to main branch: Article view and tabs

https://gerrit.wikimedia.org/r/460180

gerritbot added a comment.Sep 26 2018, 5:01 PM

Change 460448 merged by jenkins-bot:
[apps/android/wikipedia@master] Merge prototype A to main branch: Main nav drawer

https://gerrit.wikimedia.org/r/460448

gerritbot added a comment.Sep 26 2018, 5:06 PM

Change 460456 merged by jenkins-bot:
[apps/android/wikipedia@master] Merge prototype A to main branch: Scrollable controller ToC

https://gerrit.wikimedia.org/r/460456

cooltey moved this task from Code Review to Design signoff on the Wikipedia-Android-App ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Sep 27 2018, 3:52 PM
cmadeo moved this task from Design signoff to Ready for signoff on the Wikipedia-Android-App ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 11 2018, 2:30 PM
cmadeo subscribed.

Looks good to me!

Dbrant closed this task as Resolved.Nov 1 2018, 5:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits