| Ryasmeen | |
| Sep 10 2018, 7:43 PM |
| F26191950: image.png | |
| Sep 24 2018, 11:55 PM |
| F25816699: Screen Shot 2018-09-13 at 3.18.46 PM.png | |
| Sep 13 2018, 7:23 PM |
| F25757184: Screen Shot 2018-09-10 at 12.38.35 PM.png | |
| Sep 10 2018, 7:43 PM |
The text "Get quick previews of a topic while reading a page" for Page previews option under Reading preferences section on Special: Preferences> Appearance tab is italicized. Can it not have the same style as any other inline help text?
It's not only weirdly italicized, it's also a <p> which shouldn't be a child element of a label.
This spot has no need for emphasis, and the use of the p is indeed puzzling.
Probably should be: Page previews: Lorem ipsum...
Change 460142 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Popups@master] Remove unique and misplaced italicized text from preferences setting
@Izno The patch above is just removing italicized text, as we would negatively impact the layout of current Special:Preferences by putting it on one line. We'll pick the remaining parts up after OOUIfied rollout is done.
Change 460142 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove unique and misplaced italicized text from preferences setting
@alexhollender: A friendly heads up that, per T203992#4579032, this change will be live on all wikis next Thursday (2018/09/20) and so should be reviewed by you. You can see the change in action here: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering
@phuedx seems like something is off, assuming what's expected is the screenshot in the description (without the text being italicized). This is what I'm seeing:
@alexhollender There's two different things happening, the transformation of Special:Preferences to OOUI, a subtask of T180538: Improve Special:Preferences UI/UX. @Ryasmeen went through all settings to capture inconsistencies and the italicized text was one. You can preview it at https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?ooui=1
What you're looking at, is the current (and soon to go, planned for next week) version of Special:Preferences. As I've stated in T203992#4578797 the italicized text was off in current and future OOUI implementation, therefore provided the patch to remove italics. We gonna follow-up once OOUI transforming patch is merged, to also get rid of the paragraph separation, which won't make sense in new layout.
@Volker_E thanks for the clarification. Confirming that the text is no longer italicized and moving to QA.
@Volker_E - when are we expecting the OOUI rollout? Not sure if I should split the second part of this task off into a separate item or wait for the rollout and do it as one.
@ovasileva It's already on the way, https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences
will be rolled-out on normal deployment train starting next Tuesday to the wiki near you.
Sounds good, I'll move this out of our sprint for now. @Volker_E - feel free to close whenever you think is appropriate after the deployment
Change 462603 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Popups@master] Amend preferences message to unify with messages elsewhere
@alexhollender @ovasileva Short amendment from our conversation, where we talked about using a '–' as separator. The other messages laid out similar are provided with extra information in brackets and a ':' at the end of line when it's followed by any widget. In contrast to messages that are labelling a widget side-by-side.
Result (with patch provided):
@alexhollender @ovasileva Short amendment from our conversation, where we talked about using a '–' as separator. The other messages laid out similar are provided with extra information in brackets and a ':' at the end of line when it's followed by any widget. In contrast to messages that are labelling a widget side-by-side.
Result (with patch provided):
looks good to me!
Change 462603 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Amend preferences message to unify with messages elsewhere