I don't have the time to check this myself right now, but I think this is similar/identical to T203879: When editing an old version of a page, the VisualEditor shows the diff to that old version and not to the most recent version?

In T204007#4573725, @Cirdan wrote:

I don't have the time to check this myself right now, but I think this is similar/identical to T203879: When editing an old version of a page, the VisualEditor shows the diff to that old version and not to the most recent version?

That was my hypothesis as well, but both the revisions in question and the current revision have the infobox present, so I don't think it is? It's quite possible I'm misunderstanding as well. I'd appreciate it if you could double-check this for me, when you next get a chance. :-)

Change 460020 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use data.cloneElements when converting pasted wikitext

https://gerrit.wikimedia.org/r/460020

Verified on https://en.wikipedia.org/wiki/User:ESanders_(WMF)/sandbox?veaction=edit by monkey-patching the above changeset.

Change 470503 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Fix wikitext paste test

https://gerrit.wikimedia.org/r/470503

Change 460020 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Use data.cloneElements when converting pasted wikitext

https://gerrit.wikimedia.org/r/460020

Not a new shared build failure. Just the usual VE/Cite circular dependency that we've had for five years now.

Change 470503 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix wikitext paste test

https://gerrit.wikimedia.org/r/470503

No, it's not that one.

5 minutes after merging https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/460020/, all commits to core and extensions are consistently 2-3 of their builds fail with the below error:

SUMMARY:
✔ 1420 tests completed
ℹ 5 tests skipped
✖ 1 test failed

FAILED TESTS:
  ve.ui.MWWikitextStringTransferHandler (Cite)
    ✖ convert
      HeadlessChrome 0.0.0 (Linux 0.0.0)
    Simple reference: data match
    Expected: [
      {
        "attributes": {
          "contentsUsed": true,
          "listGroup": "mwReference/",
          "listIndex": 0,
          "listKey": "auto/0",
          "mw": {
            "attrs": {},
            "body": {
              "id": "mw-reference-text-cite_note-1"
            },
            "name": "ref"
          },
          "originalMw": "{\"name\":\"ref\",\"body\":{\"id\":\"mw-reference-text-cite_note-1\"},\"attrs\":{}}",
          "refGroup": "",
          "refListItemId": "mw-reference-text-cite_note-1"
        },
        "type": "mwReference"
      },
      {
        "type": "/mwReference"
      },
      {
        "type": "internalList"
      },
      {
        "type": "internalItem"
      },
      {
        "internal": {
          "generated": "wrapper"
        },
        "type": "paragraph"
      },
      "F",
      "o",
      "o",
      {
        "type": "/paragraph"
      },
      {
        "type": "/internalItem"
      },
      {
        "type": "/internalList"
      }
    ]
    Actual: [
      {
        "attributes": {
          "listGroup": "mwReference/",
          "listIndex": 0,
          "listKey": "auto/0",
          "refGroup": "",
          "refListItemId": "mw-reference-text-cite_note-1"
        },
        "type": "mwReference"
      },
      {
        "type": "/mwReference"
      },
      {
        "type": "internalList"
      },
      {
        "type": "internalItem"
      },
      {
        "internal": {
          "generated": "wrapper"
        },
        "type": "paragraph"
      },
      "F",
      "o",
      "o",
      {
        "type": "/paragraph"
      },
      {
        "type": "/internalItem"
      },
      {
        "type": "/internalList"
      }
    ]
        at

This shouldn't be surprising because https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/460020/ was already failing its own tests on Gerrit, and was forcefully merged without Jenkins passing.

The details of this new assertion failure are different from the "usual" VE/Cite flaky test, which is indeed old but fairly infrequent. This is happening on all commits.

In T204007#4704778, @gerritbot wrote:

Change 470503 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix wikitext paste test

https://gerrit.wikimedia.org/r/470503

Thanks :)

In T204007#4704782, @Krinkle wrote:

No, it's not that one.

Yes, it is. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/470503 and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/460020/ depend on each other. It is still not possible for CI to merge them, so we have to bypass, as always.

5 minutes after merging https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/460020/, all commits to core and extensions are consistently 2-3 of their builds fail with the below error

Obviously.

The details of this new assertion failure are different from the "usual" VE/Cite flaky test, which is indeed old but fairly infrequent. This is happening on all commits.

What flaky Cite test? We're not talking about a flaky test.

Checked on Beta cluster since the replication step requires saving the edit. Looks fixed on Beta cluster.